Re: [PATCHv3 06/10] crypto: add rocksoft 64b crc framework

Christoph Hellwig
2022-02-25T16:11:37Z

On Tue, Feb 22, 2022 at 12:09:07PM -0800, Keith Busch wrote:
> On Tue, Feb 22, 2022 at 11:50:42AM -0800, Eric Biggers wrote:
> > On Tue, Feb 22, 2022 at 08:31:40AM -0800, Keith Busch wrote:
> > > +config CRYPTO_CRC64_ROCKSOFT
> > > + tristate "Rocksoft Model CRC64 algorithm"
> > > + depends on CRC64
> > > + select CRYPTO_HASH
> > > + help
> > > + Rocksoft Model CRC64 computation is being cast as a crypto
> > > + transform. This allows for faster crc64 transforms to be used
> > > + if they are available.
> >
> > The first sentence of this help text doesn't make sense.
>
> Much of the this patch is a copy from the equivalent T10DIF option,
> which says the same as above. I meant to revist these help texts because
> they don't make sense to me either. I'll be sure to do that for the next
> version.

It might make sense to make CRC_T10DIF an invisible option as well
and drop the help text entirely.