Re: [PATCH v2 08/18] dept: Apply Dept to wait_for_completion()/complete()

kernel test robot
2022-02-22T19:26:05Z

Hi Byungchul,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/sched/core]
[also build test WARNING on linux/master linus/master v5.17-rc5]
[cannot apply to tip/locking/core hnaz-mm/master next-20220217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Byungchul-Park/DEPT-Dependency-Tracker/20220220-185528
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ed3b362d54f0038cafc985248350d301af7af686
reproduce: make htmldocs

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> include/linux/completion.h:121: warning: expecting prototype for init_completion(). Prototype was for __init_completion() instead

vim +121 include/linux/completion.h

8b3db9c542e18b7 Ingo Molnar 2006-07-03 110
65eb3dc609dec17 Kevin Diggs 2008-08-26 111 /**
ee2f154a598e96d Randy Dunlap 2010-10-26 112 * init_completion - Initialize a dynamically allocated completion
c32f74ab2872994 Wolfram Sang 2013-11-14 113 * @x: pointer to completion structure that is to be initialized
65eb3dc609dec17 Kevin Diggs 2008-08-26 114 *
65eb3dc609dec17 Kevin Diggs 2008-08-26 115 * This inline function will initialize a dynamically created completion
65eb3dc609dec17 Kevin Diggs 2008-08-26 116 * structure.
65eb3dc609dec17 Kevin Diggs 2008-08-26 117 */
82b6a46bab5dcb0 Byungchul Park 2022-02-19 118 static inline void __init_completion(struct completion *x,
82b6a46bab5dcb0 Byungchul Park 2022-02-19 119 struct dept_key *dkey,
82b6a46bab5dcb0 Byungchul Park 2022-02-19 120 const char *name)
^1da177e4c3f415 Linus Torvalds 2005-04-16 @121 {
^1da177e4c3f415 Linus Torvalds 2005-04-16 122 x->done = 0;
82b6a46bab5dcb0 Byungchul Park 2022-02-19 123 dept_wfc_init(&x->dmap, dkey, 0, name);
a5c6234e10280b3 Thomas Gleixner 2020-03-21 124 init_swait_queue_head(&x->wait);
^1da177e4c3f415 Linus Torvalds 2005-04-16 125 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 126

---
0-DAY CI Kernel Test Service, Intel Corporation