public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Miguel Ojeda <ojeda@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Lars Poeschel <poeschel@lemonage.de>
Subject: [PATCH v1 1/3] auxdisplay: lcd2s: Fix lcd2s_redefine_char() feature
Date: Wed, 23 Feb 2022 17:47:16 +0200	[thread overview]
Message-ID: <20220223154718.83500-1-andriy.shevchenko@linux.intel.com> (raw)

It seems that the lcd2s_redefine_char() has never been properly
tested. The buffer is filled by DEF_CUSTOM_CHAR command followed
by the character number (from 0 to 7), but immediately after that
these bytes are got rewritten by the decoded hex stream.

Fix the index to fill the buffer after the command and number.

Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display")
Cc: Lars Poeschel <poeschel@lemonage.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/auxdisplay/lcd2s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/auxdisplay/lcd2s.c b/drivers/auxdisplay/lcd2s.c
index 38ba08628ccb..ea9d75ad4f16 100644
--- a/drivers/auxdisplay/lcd2s.c
+++ b/drivers/auxdisplay/lcd2s.c
@@ -238,7 +238,7 @@ static int lcd2s_redefine_char(struct charlcd *lcd, char *esc)
 	if (buf[1] > 7)
 		return 1;
 
-	i = 0;
+	i = 2;
 	shift = 0;
 	value = 0;
 	while (*esc && i < LCD2S_CHARACTER_SIZE + 2) {
-- 
2.34.1


             reply	other threads:[~2022-02-23 15:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23 15:47 Andy Shevchenko [this message]
2022-02-23 15:47 ` [PATCH v1 2/3] auxdisplay: lcd2s: Fix memory leak in ->remove() Andy Shevchenko
2022-03-03  1:19   ` Miguel Ojeda
2022-02-23 15:47 ` [PATCH v1 3/3] auxdisplay: lcd2s: Use proper API to free the instance of charlcd object Andy Shevchenko
2022-03-03  1:19   ` Miguel Ojeda
2022-03-02 15:47 ` [PATCH v1 1/3] auxdisplay: lcd2s: Fix lcd2s_redefine_char() feature Andy Shevchenko
2022-03-02 16:12 ` Geert Uytterhoeven
2022-03-03  1:18 ` Miguel Ojeda
2022-03-03 10:46   ` Miguel Ojeda
2022-03-03 11:02     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220223154718.83500-1-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=poeschel@lemonage.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox