* [PATCH] erofs: fix ztailpacking on > 4GiB filesystems
@ 2022-02-22 3:31 Gao Xiang
2022-02-23 8:57 ` Yue Hu
2022-03-02 2:49 ` Chao Yu
0 siblings, 2 replies; 4+ messages in thread
From: Gao Xiang @ 2022-02-22 3:31 UTC (permalink / raw)
To: linux-erofs, Chao Yu, Yue Hu; +Cc: LKML, Gao Xiang
z_idataoff here is an absolute physical offset, so it should use
erofs_off_t (64 bits at least). Otherwise, it'll get trimmed and
cause the decompresion failure.
Fixes: ab92184ff8f1 ("erofs: add on-disk compressed tail-packing inline support")
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
---
fs/erofs/internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
index b8272fb95fd6..5aa2cf2c2f80 100644
--- a/fs/erofs/internal.h
+++ b/fs/erofs/internal.h
@@ -325,7 +325,7 @@ struct erofs_inode {
unsigned char z_algorithmtype[2];
unsigned char z_logical_clusterbits;
unsigned long z_tailextent_headlcn;
- unsigned int z_idataoff;
+ erofs_off_t z_idataoff;
unsigned short z_idata_size;
};
#endif /* CONFIG_EROFS_FS_ZIP */
--
2.24.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] erofs: fix ztailpacking on > 4GiB filesystems
2022-02-22 3:31 [PATCH] erofs: fix ztailpacking on > 4GiB filesystems Gao Xiang
@ 2022-02-23 8:57 ` Yue Hu
2022-03-02 2:49 ` Chao Yu
1 sibling, 0 replies; 4+ messages in thread
From: Yue Hu @ 2022-02-23 8:57 UTC (permalink / raw)
To: Gao Xiang; +Cc: linux-erofs, Chao Yu, Yue Hu, LKML, zhangwen, shaojunjun
On Tue, 22 Feb 2022 11:31:18 +0800
Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
> z_idataoff here is an absolute physical offset, so it should use
> erofs_off_t (64 bits at least). Otherwise, it'll get trimmed and
> cause the decompresion failure.
>
> Fixes: ab92184ff8f1 ("erofs: add on-disk compressed tail-packing inline support")
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> ---
> fs/erofs/internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
> index b8272fb95fd6..5aa2cf2c2f80 100644
> --- a/fs/erofs/internal.h
> +++ b/fs/erofs/internal.h
> @@ -325,7 +325,7 @@ struct erofs_inode {
> unsigned char z_algorithmtype[2];
> unsigned char z_logical_clusterbits;
> unsigned long z_tailextent_headlcn;
> - unsigned int z_idataoff;
> + erofs_off_t z_idataoff;
> unsigned short z_idata_size;
> };
> #endif /* CONFIG_EROFS_FS_ZIP */
Reviewed-by: Yue Hu <huyue2@yulong.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] erofs: fix ztailpacking on > 4GiB filesystems
2022-02-22 3:31 [PATCH] erofs: fix ztailpacking on > 4GiB filesystems Gao Xiang
2022-02-23 8:57 ` Yue Hu
@ 2022-03-02 2:49 ` Chao Yu
2022-03-02 3:03 ` Gao Xiang
1 sibling, 1 reply; 4+ messages in thread
From: Chao Yu @ 2022-03-02 2:49 UTC (permalink / raw)
To: Gao Xiang, linux-erofs, Yue Hu; +Cc: LKML
On 2022/2/22 11:31, Gao Xiang wrote:
> z_idataoff here is an absolute physical offset, so it should use
> erofs_off_t (64 bits at least). Otherwise, it'll get trimmed and
> cause the decompresion failure.
>
> Fixes: ab92184ff8f1 ("erofs: add on-disk compressed tail-packing inline support")
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] erofs: fix ztailpacking on > 4GiB filesystems
2022-03-02 2:49 ` Chao Yu
@ 2022-03-02 3:03 ` Gao Xiang
0 siblings, 0 replies; 4+ messages in thread
From: Gao Xiang @ 2022-03-02 3:03 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-erofs, Yue Hu, LKML
On Wed, Mar 02, 2022 at 10:49:47AM +0800, Chao Yu wrote:
> On 2022/2/22 11:31, Gao Xiang wrote:
> > z_idataoff here is an absolute physical offset, so it should use
> > erofs_off_t (64 bits at least). Otherwise, it'll get trimmed and
> > cause the decompresion failure.
> >
> > Fixes: ab92184ff8f1 ("erofs: add on-disk compressed tail-packing inline support")
> > Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
>
> Reviewed-by: Chao Yu <chao@kernel.org>
Thanks Chao. Yeah, I will submit it this week..
Thanks,
Gao Xiang
>
> Thanks,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-02 3:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-22 3:31 [PATCH] erofs: fix ztailpacking on > 4GiB filesystems Gao Xiang
2022-02-23 8:57 ` Yue Hu
2022-03-02 2:49 ` Chao Yu
2022-03-02 3:03 ` Gao Xiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox