From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A553C433EF for ; Thu, 24 Feb 2022 20:04:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234166AbiBXUF2 convert rfc822-to-8bit (ORCPT ); Thu, 24 Feb 2022 15:05:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233076AbiBXUFY (ORCPT ); Thu, 24 Feb 2022 15:05:24 -0500 Received: from mxout03.lancloud.ru (mxout03.lancloud.ru [45.84.86.113]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F5ED25D6E0 for ; Thu, 24 Feb 2022 12:04:53 -0800 (PST) Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout03.lancloud.ru EA3F8208EDBF Received: from LanCloud Received: from LanCloud Received: from LanCloud Received: from LanCloud From: Denis Glazkov CC: Denis Glazkov , Mehmet Kayaalp , Mimi Zohar , "David Howells" , "linux-kernel@vger.kernel.org" Subject: [PATCH] KEYS: fix memory leak when reading certificate fails Thread-Topic: [PATCH] KEYS: fix memory leak when reading certificate fails Thread-Index: AQHYKbnIi4DOa4Y+OEmPMaAeEEMw7A== Date: Thu, 24 Feb 2022 20:04:51 +0000 Message-ID: <20220224200437.201705-1-d.glazkov@omp.ru> Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.11.137] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the `read_file` function of `insert-sys-cert.c` script, if the data is read incorrectly, the memory allocated for the `buf` array is not freed. Fixes: c4c361059585 ("KEYS: Reserve an extra certificate symbol for inserting without recompiling") Signed-off-by: Denis Glazkov --- scripts/insert-sys-cert.c | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/insert-sys-cert.c b/scripts/insert-sys-cert.c index 8902836c2342..b98a0b12f16f 100644 --- a/scripts/insert-sys-cert.c +++ b/scripts/insert-sys-cert.c @@ -251,6 +251,7 @@ static char *read_file(char *file_name, int *size) if (read(fd, buf, *size) != *size) { perror("File read failed"); close(fd); + free(buf); return NULL; } close(fd); -- 2.25.1