From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D1AEC433EF for ; Mon, 28 Feb 2022 11:04:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235348AbiB1LFX (ORCPT ); Mon, 28 Feb 2022 06:05:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230369AbiB1LFU (ORCPT ); Mon, 28 Feb 2022 06:05:20 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C072E25E82 for ; Mon, 28 Feb 2022 03:04:41 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 532E968AFE; Mon, 28 Feb 2022 12:04:38 +0100 (CET) Date: Mon, 28 Feb 2022 12:04:38 +0100 From: Christoph Hellwig To: Robin Murphy Cc: Christoph Hellwig , iommu@lists.linux-foundation.org, joro@8bytes.org, will@kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dma-mapping: remove CONFIG_DMA_REMAP Message-ID: <20220228110438.GA10232@lst.de> References: <20220227143533.357356-1-hch@lst.de> <4802e9fd-733f-3246-92f3-05f590e05d37@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4802e9fd-733f-3246-92f3-05f590e05d37@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 28, 2022 at 10:32:54AM +0000, Robin Murphy wrote: > Is it even possible to hit this case now? From a quick look, all the > architectures defining HIGHMEM either have an explicit dependency on MMU or > don't allow deselecting it anyway (plus I don't see how HIGHMEM && !MMU > could work in general), so I'm pretty sure this whole chunk should go away > now. > > With that (or if there *is* some subtle wacky case where PageHighmem() can > actually return true for !MMU, a comment to remind us in future), No, you're right - I don't think we can support highmem on !CONFIG_MMU.