From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED9D5C433FE for ; Tue, 1 Mar 2022 14:05:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235096AbiCAOGa (ORCPT ); Tue, 1 Mar 2022 09:06:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234891AbiCAOG2 (ORCPT ); Tue, 1 Mar 2022 09:06:28 -0500 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7EAE52E36 for ; Tue, 1 Mar 2022 06:05:46 -0800 (PST) Received: by mail-qk1-x732.google.com with SMTP id n185so12960027qke.5 for ; Tue, 01 Mar 2022 06:05:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wtjizohg2CiwaFsaFvPT2wpJpMfkgawgg3Rxz5LmFXY=; b=GsRBTV8VD/o9MySrOhudutHADbuYL9ep+ZxLIVZMNyyhVObhTfhbQKDkqaWRomFsGq 1aMX+BXHg9wrjqRQtEQ/rdwOZ+r0PJZmslM7L2fWNkzcWorK3mxoYmkUenKeE/IQp2zT PfsBEkDUvDjHmmPoi+BdD1txx9RyeAeZOBmv+Co8oHJF1nRUNBPN/vcCSfdxgUlWJtMI RFrDwr0/c7+BC0eFSdtRqiGO/Ku6kYR9n3K6ARHTgS1/wBLRniW7lSlCjaoVNTKa2Pja YkYoAn4N5Xbq1YwIgQizbvOZ87EwU0eBxKhm2ByIgZBeX26qUESOJF0PtcEau2YRMQni k2sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wtjizohg2CiwaFsaFvPT2wpJpMfkgawgg3Rxz5LmFXY=; b=i7JboQHFOJXifUtZ3D0g2XWEwt9efZJkszZ422em/BmWd4ec2tnu/K69dh8hQ8rP3l FcLezi4Yr4Wigs+2/uywFCpl/mepeK1ZfybYD7nr3PW3HZsVmgd5HqBIVHC1nDI8A+XP rrxD8GQ5NU4igGqE5Ebojtfxk4yVVF57llhfGtESDPcRFXcebs4BImR6txCMf4CO8yS+ oU485zoPR+S4Ht1uFxUqRSzSBjwAjgO0PaD4dLBb4uIPWF6c/dLNjTVf4CM1R7i04fwG Mg447bVMOtFG3OIDjO+mBVs5ImPqO65M0WmRzI8WWOoBCFL3uJ+nkzQpcjdRn7nErtJt 7c5Q== X-Gm-Message-State: AOAM531OBQdhV4KZLmv8PVbhPSanC+W2Af4iRmik2DQNujjB53OAqHQy KNrYJda0MQ7g85B0Bu7mvQqiWROhvyaHgQ== X-Google-Smtp-Source: ABdhPJwI0NqfzPP+GkfqwR8OmC5EsTEp+yRSTD28VkEDjkdvz0BPphnx25Tzuqxb1A/beX02YKpz9g== X-Received: by 2002:a37:a246:0:b0:49b:679a:2f2b with SMTP id l67-20020a37a246000000b0049b679a2f2bmr13467991qke.702.1646143545990; Tue, 01 Mar 2022 06:05:45 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id d4-20020a05620a136400b0060dda40b3ecsm6536312qkl.30.2022.03.01.06.05.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Mar 2022 06:05:45 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nP38K-003W39-LL; Tue, 01 Mar 2022 10:05:44 -0400 Date: Tue, 1 Mar 2022 10:05:44 -0400 From: Jason Gunthorpe To: Lino Sanfilippo Cc: peterhuewe@gmx.de, jarkko@kernel.org, stefanb@linux.vnet.ibm.com, James.Bottomley@hansenpartnership.com, David.Laight@ACULAB.COM, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, p.rosenberger@kunbus.com, Lino Sanfilippo , stable@vger.kernel.org Subject: Re: [PATCH v8 1/1] tpm: fix reference counting for struct tpm_chip Message-ID: <20220301140544.GF6468@ziepe.ca> References: <20220301022108.30310-1-LinoSanfilippo@gmx.de> <20220301022108.30310-2-LinoSanfilippo@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220301022108.30310-2-LinoSanfilippo@gmx.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 01, 2022 at 03:21:08AM +0100, Lino Sanfilippo wrote: > @@ -653,8 +623,10 @@ void tpm_chip_unregister(struct tpm_chip *chip) > if (IS_ENABLED(CONFIG_HW_RANDOM_TPM) && !tpm_is_firmware_upgrade(chip)) > hwrng_unregister(&chip->hwrng); > tpm_bios_log_teardown(chip); > - if (chip->flags & TPM_CHIP_FLAG_TPM2 && !tpm_is_firmware_upgrade(chip)) > + if (chip->flags & TPM_CHIP_FLAG_TPM2 && !tpm_is_firmware_upgrade(chip)) { > cdev_device_del(&chip->cdevs, &chip->devs); > + put_device(&chip->devs); > + } I would put those two lines in a function bside tpm_devs_add() as well, more modular. It looks like a good idea to me Jason