* [PATCH -next] drm/amdgpu: clean up some inconsistent indenting
@ 2022-03-03 1:52 Yang Li
2022-03-03 7:09 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2022-03-03 1:52 UTC (permalink / raw)
To: airlied
Cc: daniel, Xinhui.Pan, christian.koenig, alexander.deucher, amd-gfx,
dri-devel, linux-kernel, Yang Li, Abaci Robot
Eliminate the follow smatch warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:413 amdgpu_get_xgmi_hive()
warn: inconsistent indenting
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
index 91817a31f3e1..4ff6e06babca 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
@@ -410,14 +410,14 @@ struct amdgpu_hive_info *amdgpu_get_xgmi_hive(struct amdgpu_device *adev)
*/
if (adev->reset_domain->type != XGMI_HIVE) {
hive->reset_domain = amdgpu_reset_create_reset_domain(XGMI_HIVE, "amdgpu-reset-hive");
- if (!hive->reset_domain) {
- dev_err(adev->dev, "XGMI: failed initializing reset domain for xgmi hive\n");
- ret = -ENOMEM;
- kobject_put(&hive->kobj);
- kfree(hive);
- hive = NULL;
- goto pro_end;
- }
+ if (!hive->reset_domain) {
+ dev_err(adev->dev, "XGMI: failed initializing reset domain for xgmi hive\n");
+ ret = -ENOMEM;
+ kobject_put(&hive->kobj);
+ kfree(hive);
+ hive = NULL;
+ goto pro_end;
+ }
} else {
amdgpu_reset_get_reset_domain(adev->reset_domain);
hive->reset_domain = adev->reset_domain;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm/amdgpu: clean up some inconsistent indenting
2022-03-03 1:52 [PATCH -next] drm/amdgpu: clean up some inconsistent indenting Yang Li
@ 2022-03-03 7:09 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2022-03-03 7:09 UTC (permalink / raw)
To: Yang Li, airlied
Cc: daniel, Xinhui.Pan, alexander.deucher, amd-gfx, dri-devel,
linux-kernel, Abaci Robot
Am 03.03.22 um 02:52 schrieb Yang Li:
> Eliminate the follow smatch warning:
> drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:413 amdgpu_get_xgmi_hive()
> warn: inconsistent indenting
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> index 91817a31f3e1..4ff6e06babca 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> @@ -410,14 +410,14 @@ struct amdgpu_hive_info *amdgpu_get_xgmi_hive(struct amdgpu_device *adev)
> */
> if (adev->reset_domain->type != XGMI_HIVE) {
> hive->reset_domain = amdgpu_reset_create_reset_domain(XGMI_HIVE, "amdgpu-reset-hive");
> - if (!hive->reset_domain) {
> - dev_err(adev->dev, "XGMI: failed initializing reset domain for xgmi hive\n");
> - ret = -ENOMEM;
> - kobject_put(&hive->kobj);
> - kfree(hive);
> - hive = NULL;
> - goto pro_end;
> - }
> + if (!hive->reset_domain) {
> + dev_err(adev->dev, "XGMI: failed initializing reset domain for xgmi hive\n");
> + ret = -ENOMEM;
> + kobject_put(&hive->kobj);
> + kfree(hive);
> + hive = NULL;
> + goto pro_end;
> + }
> } else {
> amdgpu_reset_get_reset_domain(adev->reset_domain);
> hive->reset_domain = adev->reset_domain;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-03 7:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-03 1:52 [PATCH -next] drm/amdgpu: clean up some inconsistent indenting Yang Li
2022-03-03 7:09 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox