* [PATCH -next] drm/fsl-dcu: Remove unnecessary print function dev_err()
@ 2022-03-03 2:30 Yang Li
2022-03-04 8:29 ` [EXT] " Alison Wang
0 siblings, 1 reply; 3+ messages in thread
From: Yang Li @ 2022-03-03 2:30 UTC (permalink / raw)
To: alison.wang
Cc: stefan, airlied, daniel, dri-devel, linux-kernel, Yang Li,
Abaci Robot
The print function dev_err() is redundant because platform_get_irq()
already prints an error.
Eliminate the follow coccicheck warning:
./drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c:277:2-9: line 277 is
redundant because platform_get_irq() already prints an error
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
index 7a503bf08d0f..20895ea79739 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
@@ -273,10 +273,8 @@ static int fsl_dcu_drm_probe(struct platform_device *pdev)
}
fsl_dev->irq = platform_get_irq(pdev, 0);
- if (fsl_dev->irq < 0) {
- dev_err(dev, "failed to get irq\n");
+ if (fsl_dev->irq < 0)
return fsl_dev->irq;
- }
fsl_dev->regmap = devm_regmap_init_mmio(dev, base,
&fsl_dcu_regmap_config);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [EXT] [PATCH -next] drm/fsl-dcu: Remove unnecessary print function dev_err()
2022-03-03 2:30 [PATCH -next] drm/fsl-dcu: Remove unnecessary print function dev_err() Yang Li
@ 2022-03-04 8:29 ` Alison Wang
0 siblings, 0 replies; 3+ messages in thread
From: Alison Wang @ 2022-03-04 8:29 UTC (permalink / raw)
To: Yang Li
Cc: stefan@agner.ch, airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Abaci Robot
Acked-by: Alison Wang <alison.wang@nxp.com>
Best Regards,
Alison Wang
-----Original Message-----
From: Yang Li <yang.lee@linux.alibaba.com>
Sent: 2022年3月3日 10:30
To: Alison Wang <alison.wang@nxp.com>
Cc: stefan@agner.ch; airlied@linux.ie; daniel@ffwll.ch; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Yang Li <yang.lee@linux.alibaba.com>; Abaci Robot <abaci@linux.alibaba.com>
Subject: [EXT] [PATCH -next] drm/fsl-dcu: Remove unnecessary print function dev_err()
Caution: EXT Email
The print function dev_err() is redundant because platform_get_irq() already prints an error.
Eliminate the follow coccicheck warning:
./drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c:277:2-9: line 277 is redundant because platform_get_irq() already prints an error
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
index 7a503bf08d0f..20895ea79739 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
@@ -273,10 +273,8 @@ static int fsl_dcu_drm_probe(struct platform_device *pdev)
}
fsl_dev->irq = platform_get_irq(pdev, 0);
- if (fsl_dev->irq < 0) {
- dev_err(dev, "failed to get irq\n");
+ if (fsl_dev->irq < 0)
return fsl_dev->irq;
- }
fsl_dev->regmap = devm_regmap_init_mmio(dev, base,
&fsl_dcu_regmap_config);
--[Alison Wang] r
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH -next] drm/fsl-dcu: Remove unnecessary print function dev_err()
@ 2024-10-17 2:24 Jiapeng Chong
0 siblings, 0 replies; 3+ messages in thread
From: Jiapeng Chong @ 2024-10-17 2:24 UTC (permalink / raw)
To: stefan
Cc: alison.wang, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, dri-devel, linux-kernel, Jiapeng Chong, Abaci Robot
The print function dev_err() is redundant because
platform_get_irq_byname() already prints an error.
./drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c:278:2-9: line 278 is redundant because platform_get_irq() already prints an error.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11384
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
index 2b3f15f0dc56..60a7b9dbf95c 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
@@ -273,11 +273,8 @@ static int fsl_dcu_drm_probe(struct platform_device *pdev)
return ret;
}
- fsl_dev->irq = platform_get_irq(pdev, 0);
- if (fsl_dev->irq < 0) {
- dev_err(dev, "failed to get irq\n");
+ if (platform_get_irq(pdev, 0) < 0)
return fsl_dev->irq;
- }
fsl_dev->regmap = devm_regmap_init_mmio(dev, base,
&fsl_dcu_regmap_config);
--
2.32.0.3.g01195cf9f
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-17 2:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-03 2:30 [PATCH -next] drm/fsl-dcu: Remove unnecessary print function dev_err() Yang Li
2022-03-04 8:29 ` [EXT] " Alison Wang
-- strict thread matches above, loose matches on Subject: below --
2024-10-17 2:24 Jiapeng Chong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox