From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gaston Gonzalez <gascoar@gmail.com>
Cc: linux-staging@lists.linux.dev, gregkh@linuxfoundation.org,
nsaenz@kernel.org, stefan.wahren@i2se.com, ojaswin98@gmail.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: vchiq_arm: add prototype of function vchiq_platform_init()
Date: Thu, 3 Mar 2022 15:25:47 +0300 [thread overview]
Message-ID: <20220303122546.GH2794@kadam> (raw)
In-Reply-To: <b74ac90e869f71a98a04b834c4f3b5ab37bb38ea.1646255044.git.gascoar@gmail.com>
On Wed, Mar 02, 2022 at 06:36:38PM -0300, Gaston Gonzalez wrote:
> Fix "no previous prototype" W=1 warning by adding the prototype of the
> function vchiq_platform_init().
>
> Note: vchiq_platform_init() is only called once in vchiq_probe(), so
> presumably should be static function. However, making the function
> static breaks the build.
>
That's weird. I don't have an ARM cross compile set up. How does the
build break?
regards,
dan carpenter
next prev parent reply other threads:[~2022-03-03 12:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 21:36 [PATCH 0/2] staging: vc04_services: address W=1 warnings Gaston Gonzalez
2022-03-02 21:36 ` [PATCH 1/2] staging: vchiq_arm: make vchiq_platform_get_arm_state() static Gaston Gonzalez
2022-03-02 21:36 ` [PATCH 2/2] staging: vchiq_arm: add prototype of function vchiq_platform_init() Gaston Gonzalez
2022-03-03 12:25 ` Dan Carpenter [this message]
2022-03-04 19:30 ` Gaston Gonzalez
2022-03-07 7:45 ` Dan Carpenter
2022-03-14 15:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220303122546.GH2794@kadam \
--to=dan.carpenter@oracle.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=gascoar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=nsaenz@kernel.org \
--cc=ojaswin98@gmail.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox