From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDA22C433EF for ; Fri, 4 Mar 2022 18:09:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241531AbiCDSJz (ORCPT ); Fri, 4 Mar 2022 13:09:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241512AbiCDSJx (ORCPT ); Fri, 4 Mar 2022 13:09:53 -0500 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE6961C60DF for ; Fri, 4 Mar 2022 10:09:04 -0800 (PST) Received: by mail-pf1-x430.google.com with SMTP id d187so8233303pfa.10 for ; Fri, 04 Mar 2022 10:09:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yqxK85bZK7xDyQw2uCXi3loaqdFYPJjcAinZfxqk6do=; b=ocz1+Iw2gQLaJb2kUh6BCjlQE8FtpZ7onQytZBB4oTiku41XTQb2azH+A6m4FymENh NAhz4xCeV1dpJWdXtIOLKucZqrbpLU3XDDZnZu/knH/ZFLtyGFMioPHgUmN5h2xuI5s6 CMoiAVi/wR7mULEHHgmDBVlensKUZylG60Y1U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yqxK85bZK7xDyQw2uCXi3loaqdFYPJjcAinZfxqk6do=; b=1CBsHqixUlF4EfFTg3MEupOotjsPu/JT28jZAQQ4TpVWPvE8njPDIiGQJsgvP05ID5 65+N1G1TyhDuutdYcLwGoUww6i2TBd/NifVyhJoD7QBW7421Z2DFTmZxTobEqqtr7w8+ gVO2AT5A4m+HRlqvQyyxsob8obXXKr9QymnP/sz2v+7N+vM2rzYHcbjqJH+jOyuP4w21 X3GH6TdSm7eE7JK7JZFHHiaY2InFxDXDdeXh1KyS4UJujw+/j4t5GzsF7yfo9FZkNHoe Q2GD3UMjSJICI5ug8WkYw6WdL36yV4YgIQzimzrKFpDaTO9Q1ql2RlmLSBOwytJLqUAE IztA== X-Gm-Message-State: AOAM533dwbVUT/xAUnGKKmOFQtUgk3f34Kb8ZFUqT9VeVxeuk17EE3iM lKn+c5SmLV62g5yHmoSAWC9b2g== X-Google-Smtp-Source: ABdhPJx0NCCGjOT8EpZGR6/1/fL3PG5CbdMIqYeA3vaoHL7EPfBcyJQ0doJAvVQog4jtN8Af1IBekQ== X-Received: by 2002:a05:6a00:1312:b0:4e1:58c4:ddfd with SMTP id j18-20020a056a00131200b004e158c4ddfdmr44651556pfu.65.1646417344203; Fri, 04 Mar 2022 10:09:04 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id n18-20020a056a00213200b004e17d967d13sm6276262pfj.124.2022.03.04.10.09.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 10:09:03 -0800 (PST) Date: Fri, 4 Mar 2022 10:09:03 -0800 From: Kees Cook To: Nathan Chancellor Cc: Masahiro Yamada , Nick Desaulniers , Shuah Khan , llvm@lists.linux.dev, linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Peter Zijlstra Subject: Re: [PATCH v2] kbuild: Make $(LLVM) more flexible Message-ID: <202203041005.A3B985C@keescook> References: <20220304170813.1689186-1-nathan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220304170813.1689186-1-nathan@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 04, 2022 at 10:08:14AM -0700, Nathan Chancellor wrote: > [...] > > Update and reorder the documentation to reflect these new additions. > At the same time, notate that LLVM=0 is not the same as just omitting it > altogether, which has confused people in the past. Is it worth making LLVM=0 actually act the way it's expected to? > Link: https://lore.kernel.org/r/20200317215515.226917-1-ndesaulniers@google.com/ > Link: https://lore.kernel.org/r/20220224151322.072632223@infradead.org/ > Suggested-by: Masahiro Yamada > Suggested-by: Peter Zijlstra > Signed-off-by: Nathan Chancellor Looks good; minor .rst nit below... Reviewed-by: Kees Cook > [...] > -LLVM has substitutes for GNU binutils utilities. Kbuild supports ``LLVM=1`` > -to enable them. :: > - > - make LLVM=1 > - > -They can be enabled individually. The full list of the parameters: :: > +LLVM has substitutes for GNU binutils utilities. They can be enabled individually. > +The full list of supported make variables: :: ": ::" and "::" yield the same result. I think the latter is more readable in non-rendered form. *shrug* -Kees -- Kees Cook