Re: [PATCH] mtd: rawnand: omap2: Actually prevent invalid configuration and build error

Guenter Roeck
2022-02-20T00:44:21Z

On Sat, Feb 19, 2022 at 09:36:00PM +0200, Roger Quadros wrote:
> The root of the problem is that we are selecting symbols that have
> dependencies. This can cause random configurations that can fail.
> The cleanest solution is to avoid using select.
>
> This driver uses interfaces from the OMAP_GPMC driver so we have to
> depend on it instead.
>
> Fixes: 4cd335dae3cf ("mtd: rawnand: omap2: Prevent invalid configuration and build error")
> Signed-off-by: Roger Quadros <rogerq@kernel.org>

Tested-by: Guenter Roeck <linux@roeck-us.net>

> ---
> drivers/mtd/nand/raw/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> index 36e697456ec4..9b078e78f3fa 100644
> --- a/drivers/mtd/nand/raw/Kconfig
> +++ b/drivers/mtd/nand/raw/Kconfig
> @@ -42,8 +42,7 @@ config MTD_NAND_OMAP2
> tristate "OMAP2, OMAP3, OMAP4 and Keystone NAND controller"
> depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
> depends on HAS_IOMEM
> - select MEMORY
> - select OMAP_GPMC
> + depends on OMAP_GPMC
> help
> Support for NAND flash on Texas Instruments OMAP2, OMAP3, OMAP4
> and Keystone platforms.
> --
> 2.17.1
>