Re: [PATCH v3 22/39] x86/ibt: Add IBT feature, MSR and #CP handling

Peter Zijlstra
2022-03-04T20:39:05Z

On Fri, Mar 04, 2022 at 09:57:33AM -0800, Josh Poimboeuf wrote:
> On Thu, Mar 03, 2022 at 12:23:43PM +0100, Peter Zijlstra wrote:
> > +bool ibt_selftest(void)
> > +{
> > + unsigned long ret;
> > +
> > + asm (" lea ibt_selftest_ip(%%rip), %%rax\n\t"
> > + ANNOTATE_RETPOLINE_SAFE
> > + " jmp *%%rax\n\t"
> > + ASM_REACHABLE
> > + ANNOTATE_NOENDBR
> > + "ibt_selftest_ip: nop\n\t"
>
> Maybe pedantic, but I find the annotations to be less surprising if they
> come after the label:
>
> "ibt_selftest_ip:\n\t"
> ASM_REACHABLE
> ANNOTATE_NOENDBR
> "nop\n\t"

Done.