From: Jason Gunthorpe <jgg@nvidia.com>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: leonro@nvidia.com, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-next] RDMA/core: Fix ib_qp_usecnt_dec() called when error
Date: Fri, 4 Mar 2022 20:25:27 -0400 [thread overview]
Message-ID: <20220305002527.GC1248225@nvidia.com> (raw)
In-Reply-To: <20220303024232.2847388-1-yajun.deng@linux.dev>
On Thu, Mar 03, 2022 at 10:42:32AM +0800, Yajun Deng wrote:
> ib_destroy_qp() would called by ib_create_qp_user() if error, the former
> contains ib_qp_usecnt_dec(), but ib_qp_usecnt_inc() was not called before.
>
> So move ib_qp_usecnt_inc() into create_qp().
>
> Fixes: d2b10794fc13 ("RDMA/core: Create clean QP creations interface for uverbs")
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/infiniband/core/uverbs_cmd.c | 1 -
> drivers/infiniband/core/uverbs_std_types_qp.c | 1 -
> drivers/infiniband/core/verbs.c | 3 +--
> 3 files changed, 1 insertion(+), 4 deletions(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2022-03-05 0:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 2:42 [PATCH for-next] RDMA/core: Fix ib_qp_usecnt_dec() called when error Yajun Deng
2022-03-03 18:25 ` Leon Romanovsky
2022-03-05 0:25 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220305002527.GC1248225@nvidia.com \
--to=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox