Re: [RFC PATCH] pata_parport: paride replacement

Christoph Hellwig
2022-03-08T06:54:53Z

On Sun, Mar 06, 2022 at 11:36:36AM +0100, Ondrej Zary wrote:
> On Sunday 06 March 2022 09:58:25 Christoph Hellwig wrote:
> > Hi Ondrej,
> >
> > I just took a quick glance and it seems like the actual protocol
> > modules still are basically almost exactly the same ones as the
> > paride ones. Is there a way to just keep the existing modules?
> >
> > The only big thing I noticed is the host template, but at least
> > for the transitional periode we could probably allocate that
> > dynamically in the core. I think would reduce the amount of code
> > churn nicely and make review much easier.
>
> Yes, only small changes in the protocol modules regarding (un)registration.
>
> Getting the original modules work with pata_parport (like in 1st preview) required some hacks that break paride (disabling EXPORT_SYMBOLs in paride).
>
> Maybe the protocol modules can be moved (git mv) from paride and then patched? A copy would be better but there's no "git cp".

Hmm, how would be break the old PARIDE code? You'd need the new libata
support exlusive to the old PARIDE code so that only one of them can
export the registration symbols at a time. The git-mv can happen
once the old paride code is removed after a release or two.

>
> --
> Ondrej Zary
---end quoted text---