From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AE7CC433F5 for ; Mon, 7 Mar 2022 14:22:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243061AbiCGOXE (ORCPT ); Mon, 7 Mar 2022 09:23:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243168AbiCGOWy (ORCPT ); Mon, 7 Mar 2022 09:22:54 -0500 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5769886E08 for ; Mon, 7 Mar 2022 06:22:00 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 07F65C0012; Mon, 7 Mar 2022 14:21:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1646662919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rDhYU9kvWroYD/F21ltVejyktD0sL5FzrRSfr3+TnaM=; b=OWLO1mSmci0YG7DcPy81g6xKKrj2yrcBihwhkUp8cihoZ5v3HRmw2x3SaT57wgzvek5iHR wWvpAvyGly17r+IIMfuZqkj55cw7UeG1/a2e3nWuLdNr72981Hd9tO0x+0XE1Pgj0z81Po kmzMQ1mggjYxz7MU6cxbCeEOWw4r42jXIKDEs5uM4cPWp9WuSxssW0JXAr2F3/SDT1/yoQ NV9KCbJwXhd9DHH3Qmbe47guoapx8k4ZmsXm7EojrMb5zKyzOMEap2yXhoLhMd/E7KvLq1 FS3dnu4sw66Hov+kzLepHD3cTVWKT4YP1bYxkSY2jJvy+x/AE+JCMkJH4KZ9Rg== Date: Mon, 7 Mar 2022 15:21:56 +0100 From: Miquel Raynal To: Roger Quadros Cc: Randy Dunlap , Guenter Roeck , krzysztof.kozlowski@canonical.com, vigneshr@ti.com, nm@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: rawnand: omap2: Actually prevent invalid configuration and build error Message-ID: <20220307152156.1d6fb01b@xps13> In-Reply-To: References: <20220220004415.GA1519274@roeck-us.net> <4bbe337e-8cd8-a4d6-303d-d5aa21bee2e0@infradead.org> <20220304165451.0129012e@xps13> <6c09de15-1ab2-5ca8-7003-69ff3f7c4dc5@kernel.org> <20220307110357.20d50176@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Roger, rogerq@kernel.org wrote on Mon, 7 Mar 2022 14:25:48 +0200: > Hi Miquel, >=20 > On 07/03/2022 12:03, Miquel Raynal wrote: > > Hi Roger, > >=20 > > rogerq@kernel.org wrote on Sat, 5 Mar 2022 00:50:14 +0200: > > =20 > >> Hi Miquel, > >> > >> On 04/03/2022 17:54, Miquel Raynal wrote: =20 > >>> Hi Guenter, Roger, > >>> > >>> rdunlap@infradead.org wrote on Sat, 26 Feb 2022 22:55:28 -0800: > >>> =20 > >>>> On 2/19/22 16:44, Guenter Roeck wrote: =20 > >>>>> On Sat, Feb 19, 2022 at 09:36:00PM +0200, Roger Quadros wrote: = =20 > >>>>>> The root of the problem is that we are selecting symbols that have > >>>>>> dependencies. This can cause random configurations that can fail. > >>>>>> The cleanest solution is to avoid using select. > >>>>>> > >>>>>> This driver uses interfaces from the OMAP_GPMC driver so we have to > >>>>>> depend on it instead. > >>>>>> > >>>>>> Fixes: 4cd335dae3cf ("mtd: rawnand: omap2: Prevent invalid configu= ration and build error") > >>>>>> Signed-off-by: Roger Quadros =20 > >>>>> > >>>>> Tested-by: Guenter Roeck =20 > >>>> > >>>> Tested-by: Randy Dunlap =20 > >>> > >>> Sorry for noticing that just now, but there is still a problem with > >>> this patch: we now always compile-in the OMAP_GPMC driver whenever we > >>> need the NAND controller, even though it is not needed. This grows the > >>> kernel for no reason. =20 > >> > >> Sorry, I did not understand what you meant. > >> > >> We no longer explicitly enable OMAP_GPMC since we dropped the "select". > >> This fixes all build issues that were reported recently. > >> > >> MTD_NAND_OMAP2 will not be enabled if OMAP_GPMC is not since we added > >> the "depends on". This fixes the original build issue that we started = to > >> fix with select initially. =20 > >=20 > > Yes, this side is fine. > >=20 > > In the initial commit, you proposed: > >=20 > > --- a/drivers/mtd/nand/raw/Kconfig > > +++ b/drivers/mtd/nand/raw/Kconfig > > @@ -42,7 +42,8 @@ config MTD_NAND_OMAP2 > > tristate "OMAP2, OMAP3, OMAP4 and Keystone NAND controller" > > depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPIL= E_TEST > > depends on HAS_IOMEM > > + select OMAP_GPMC if ARCH_K3 > >=20 > > Which creates a dependency over OMAP_GPMC only for a single > > architecture. Which means that other OMAP platforms do not necessarily > > need OMAP_GPMC for the NAND controller to work. Now, you propose: =20 >=20 > No that is not true. Other platforms that need MTD_NAND_OMAP2 are > explicitly selecting OMAP_GPMC > i.e. in arch/arm/mach-omap2/Kconfig Ok, in this case the fix is legit, but as you said there is certainly some clean up to do on this side in a second time. > > --- a/drivers/mtd/nand/raw/Kconfig > > +++ b/drivers/mtd/nand/raw/Kconfig > > @@ -42,8 +42,7 @@ config MTD_NAND_OMAP2 > > tristate "OMAP2, OMAP3, OMAP4 and Keystone NAND controller" > > depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST > > depends on HAS_IOMEM > > depends on OMAP_GPMC > >=20 > > This means any of the other OMAP architectures will compile the GPMC > > driver even though they might not need it, which would unnecessarily > > increase the kernel size. > >=20 > > Am I missing something? =20 >=20 > MTD_NAND_OMAP2 NAND controller is a submodule of the OMAP GPMC IP. So it > cannot work without OMAP_GPMC driver. >=20 > Hope this clarifies the doubts. I was not sure anymore if there was a proper hardware dependency here because of the "select GPMC if ARCH_K3" addition. But your clarification make this more understandable now. I will send the fix to Linus. Cheers, Miqu=C3=A8l > >>> In fact, Roger once said: > >>> > >>> "We will figure out how to enable OMAP_GPMC for K3 architecture > >>> some other way." > >>> > >>> It turns out this is not what was finally proposed. Could we try yet > >>> another solution? =20 > >> > >> This issue is still present i.e. we cannot enable MTD_NAND_OMAP2 drive= r on > >> K3 platform since OMAP_GPMC config is hidden and not select-able > >> by user or defconfig file. > >> > >> But it is not yet a deal breaker since NAND on K3 is not yet enabled u= pstream. > >> > >> For this I think OMAP_GPMC has to be a visible config entry and select= -able > >> from a defconfig file as I had done initially [1]. > >> > >> Now we have a lot of explanation to write as to why we need to do it ;= ) =20 > >=20 > > We certainly do :) > > =20 > >> [1] - https://lore.kernel.org/lkml/20211123102607.13002-3-rogerq@kerne= l.org/ > >> =20 > >=20 > > Thanks, > > Miqu=C3=A8l =20 >=20 > cheers, > -roger