Re: [PATCH v2] gpio: ts4900: Do not set DAT and OE together

Kris Bahnsen
2022-03-09T18:03:38Z

On Wed, 2022-03-09 at 09:32 +0100, Bartosz Golaszewski wrote:
> On Tue, Mar 8, 2022 at 7:19 PM Kris Bahnsen <kris@embeddedts.com> wrote:
> >
> > diff --git a/drivers/gpio/gpio-ts4900.c b/drivers/gpio/gpio-ts4900.c
> > index d885032cf814..fbabfca030c0 100644
> > --- a/drivers/gpio/gpio-ts4900.c
> > +++ b/drivers/gpio/gpio-ts4900.c
> > @@ -1,7 +1,8 @@
> > +// SPDX-License-Identifier: GPL-2.0
>
> This is not part of the fix, please send a separate patch that comes
> after the fix adding the SPDX identifier.
>
> > /*
> > * Digital I/O driver for Technologic Systems I2C FPGA Core
> > *
> > - * Copyright (C) 2015 Technologic Systems
> > + * Copyright (C) 2015-2018 Technologic Systems
> > * Copyright (C) 2016 Savoir-Faire Linux
> > *
> > * This program is free software; you can redistribute it and/or
>
> If you're adding the SPDX identifier, you can drop the license boilerplate here.
>
> Bart
>

Thanks for the feedback. I'll get a v3 series out soon to address these.

Kris