Re: [PATCH 4.19 00/18] 4.19.234-rc1 review

Greg Kroah-Hartman
2022-03-10T12:25:21Z

On Thu, Mar 10, 2022 at 09:51:12AM +0000, Sudip Mukherjee wrote:
> On Thu, Mar 10, 2022 at 9:18 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Mar 09, 2022 at 06:08:19PM +0000, Sudip Mukherjee wrote:
> > > Hi Greg,
> > >
> > > On Wed, Mar 9, 2022 at 4:03 PM Greg Kroah-Hartman
> > > <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > This is the start of the stable review cycle for the 4.19.234 release.
> > > > There are 18 patches in this series, all will be posted as a response
> > > > to this one. If anyone has any issues with these being applied, please
> > > > let me know.
> > > >
> > > > Responses should be made by Fri, 11 Mar 2022 15:58:48 +0000.
> > > > Anything received after that time might be too late.
> > >
> > > My tests are still running, but just an initial result for you,
> > >
> > > x86_64 defconfig fails with:
> > > arch/x86/kernel/cpu/bugs.c: In function 'spectre_v2_select_mitigation':
> > > arch/x86/kernel/cpu/bugs.c:973:41: error: implicit declaration of
> > > function 'unprivileged_ebpf_enabled'
> > > [-Werror=implicit-function-declaration]
> > > 973 | if (mode == SPECTRE_V2_EIBRS && unprivileged_ebpf_enabled())
> >
> > It's in a .h file, how can it be undefined? Must be a include path
> > somewhere, let me dig...
>
> Looks like the problem is that both "static inline bool
> unprivileged_ebpf_enabled(void)" are in the "#ifdef
> CONFIG_BPF_SYSCALL" section of include/linux/bpf.h.
> I think the one returning false should be in the #else section.

Ah, good catch!

I've fixed this up for 4.19 and 5.4 now, will do some build tests and
then push out new -rc2 release for all branches as I think that should
be all of the reported problems fixed.

Now on to the next new round of build failures! :)

thanks,

greg k-h