From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A671FC433EF for ; Wed, 9 Mar 2022 16:26:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232735AbiCIQ1d (ORCPT ); Wed, 9 Mar 2022 11:27:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238117AbiCIQVS (ORCPT ); Wed, 9 Mar 2022 11:21:18 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC7411520D8; Wed, 9 Mar 2022 08:18:54 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7BB0AB82020; Wed, 9 Mar 2022 16:18:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DEC0C340EC; Wed, 9 Mar 2022 16:18:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646842732; bh=18sop7HHeHWk2N9tOaxxTwb116X8umHAw2ytwpnKPGs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X/a5pZCcZzyJfR81F3d3B7sOxCyRplkTyYPpj9OSv54ljOzaTLZ2RNhpzzDWgb0hT l+y/CJvvk8tgo4MKHRYPhNlPIPzeuUfqjrl3noAdFduUTXQqjvtn8YxDfvxcC8Y9x6 WauQ9xZF9p7pdMTHKz6atmYLvM+F/OvTMwg8NaawOwFYKE6LcKXf9FUUS3AUQIM+UD Y/3+51ZqslejkEOxhXQ0tEWTP98UZpCmAp5RI1CoCPzkNvRjyytiw/MUxJezOS29Ld ru4YhsNoAqy2o/moUaccqf9LPt5630/KTnPmcZMwf8uQ486JDWMv1ziIGdUkwrbBSf LSgL5hldIpFfw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jia-Ju Bai , TOTE Robot , "David S . Miller" , Sasha Levin , 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.16 17/27] atm: firestream: check the return value of ioremap() in fs_init() Date: Wed, 9 Mar 2022 11:16:54 -0500 Message-Id: <20220309161711.135679-17-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220309161711.135679-1-sashal@kernel.org> References: <20220309161711.135679-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia-Ju Bai [ Upstream commit d4e26aaea7f82ba884dcb4acfe689406bc092dc3 ] The function ioremap() in fs_init() can fail, so its return value should be checked. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/atm/firestream.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c index 3bc3c314a467..4f67404fe64c 100644 --- a/drivers/atm/firestream.c +++ b/drivers/atm/firestream.c @@ -1676,6 +1676,8 @@ static int fs_init(struct fs_dev *dev) dev->hw_base = pci_resource_start(pci_dev, 0); dev->base = ioremap(dev->hw_base, 0x1000); + if (!dev->base) + return 1; reset_chip (dev); -- 2.34.1