From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DCC3C433FE for ; Wed, 9 Mar 2022 16:44:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235137AbiCIQpt (ORCPT ); Wed, 9 Mar 2022 11:45:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238562AbiCIQbb (ORCPT ); Wed, 9 Mar 2022 11:31:31 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A99C199E0B; Wed, 9 Mar 2022 08:25:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 79E36619CF; Wed, 9 Mar 2022 16:25:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B951C340E8; Wed, 9 Mar 2022 16:25:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646843157; bh=TkkZj9aVcrLNI81bYLasKDlzB/c1Awu5HVrJX/PLp48=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XP3LuWBmyKmJR4YlewjGyb+DAWjCaZIcLeAhpkKze8XH65/szNo1uJ6m2yY9rQcBk ZzhszSTnEmnEFlMyKfPQ3Z72abxgDsV2WlvX72vWHbk9NYn4kkaMrsFqTQ+qQPFgn2 LVlBBASAvVxstYDBSpgnfPzn1lqmHPMsUBgPQjZJ/ov69h/EPh0IdyIHZkUZo2pCJZ btw9djwl3dTgv35YI9p31nkKktBvebOM+thklR+Hl3QHEhkqEQZpZUwbPBvLey0GZX cPUxI36u1nvSgcsheY6Ck+WDTXbhgzbImbN6M4fmpohPm8mgrEcUlkoaTSWRbeyvC6 B69bGTZpmvJoA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jia-Ju Bai , TOTE Robot , "David S . Miller" , Sasha Levin , 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 09/14] atm: firestream: check the return value of ioremap() in fs_init() Date: Wed, 9 Mar 2022 11:25:02 -0500 Message-Id: <20220309162508.137035-9-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220309162508.137035-1-sashal@kernel.org> References: <20220309162508.137035-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia-Ju Bai [ Upstream commit d4e26aaea7f82ba884dcb4acfe689406bc092dc3 ] The function ioremap() in fs_init() can fail, so its return value should be checked. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/atm/firestream.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c index ef395b238816..f7880012b9a0 100644 --- a/drivers/atm/firestream.c +++ b/drivers/atm/firestream.c @@ -1692,6 +1692,8 @@ static int fs_init(struct fs_dev *dev) dev->hw_base = pci_resource_start(pci_dev, 0); dev->base = ioremap(dev->hw_base, 0x1000); + if (!dev->base) + return 1; reset_chip (dev); -- 2.34.1