From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CEA8C433F5 for ; Wed, 9 Mar 2022 18:39:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236457AbiCISkk (ORCPT ); Wed, 9 Mar 2022 13:40:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232677AbiCISkc (ORCPT ); Wed, 9 Mar 2022 13:40:32 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 365841704D7; Wed, 9 Mar 2022 10:39:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D974CB8232E; Wed, 9 Mar 2022 18:39:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 992C8C340E8; Wed, 9 Mar 2022 18:39:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646851170; bh=A1WR8Wa0q1Tb60p8NvM8B+XJXSA09o36ZvVXUiktXhQ=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=Prw/oGXFFzVWobc/hScuBsVUV9ti3ml5QS3Aj/hbhdQKs1BGgm8t9+zTq7BQvhrfY a+wdQJPv6b6f3Es1uCUhT7W6E3JsYKkgRhQQcTlpDQsW0RcqcsUssVKo+8DQ0QASDD YVL3wxDR06QnurH4hHv5EBNFzI19cgWzZGailF7NuSwZT8j4rYNuwdfv9qZnwsBEbF g7g2SrZ3ar0DFFln4fJ3JG7GuFQkDE1U26bdHMR6pyFmiZBjgrsy8nB+csq48RxCfK 8WfzSvR4r7q5kn7285DmpTt41xukXc1SUIWcym2x8lKsv+q4Rk20XOTwjAWsQiSe+J BugY1LPjdap/Q== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220303090508.1125175-1-colin.i.king@gmail.com> References: <20220303090508.1125175-1-colin.i.king@gmail.com> Subject: Re: [PATCH] clk: imx: remove redundant re-assignment of pll->base From: Stephen Boyd Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: Abel Vesa , Colin Ian King , Fabio Estevam , Michael Turquette , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Date: Wed, 09 Mar 2022 10:39:28 -0800 User-Agent: alot/0.10 Message-Id: <20220309183930.992C8C340E8@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Colin Ian King (2022-03-03 01:05:08) > There are two identical assignments of pll->base to the same value, > the second assignment is redundant and can be removed. >=20 > Cleans up cppcheck warning: > drivers/clk/imx/clk-sscg-pll.c:528:12: style: Variable 'pll->base' is > reassigned a value before the old one has been used. [redundantAssignment] >=20 > Signed-off-by: Colin Ian King > --- Applied to clk-next