Re: [PATCH v2 1/2] nvmet-tcp: support specifying the congestion-control

Mingbao Sun
2022-03-10T15:14:19Z

On Thu, 10 Mar 2022 15:20:34 +0100
Christoph Hellwig <hch@lst.de> wrote:

> On Thu, Mar 10, 2022 at 07:06:36PM +0800, Mingbao Sun wrote:
> > I feel it’s not proper to create a sysfs entry for each socket.
> > And for those sockets that do not have the exception of
> > congestion-control, it’s merely a waste of resources.
> >
> > Also, since these sockets generate and die dynamically, the info
> > exported via fs may even do not have the opportunity to be seen by
> > the user.
> >
> > Anyway, if you insist that the checking and warning here is not proper,
> > I can remove it.
>
> Something that can happen during normal operation is per definition no
> something that should be warned about.

Got.
Will remove this checking and warning in the next version.