Re: [PATCH v2 1/2] nvmet-tcp: support specifying the congestion-control

Christoph Hellwig
2022-03-10T14:25:04Z

On Thu, Mar 10, 2022 at 07:06:36PM +0800, Mingbao Sun wrote:
> I feel it’s not proper to create a sysfs entry for each socket.
> And for those sockets that do not have the exception of
> congestion-control, it’s merely a waste of resources.
>
> Also, since these sockets generate and die dynamically, the info
> exported via fs may even do not have the opportunity to be seen by
> the user.
>
> Anyway, if you insist that the checking and warning here is not proper,
> I can remove it.

Something that can happen during normal operation is per definition no
something that should be warned about.