From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 659FCC433F5 for ; Thu, 10 Mar 2022 06:33:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239817AbiCJGeJ (ORCPT ); Thu, 10 Mar 2022 01:34:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232658AbiCJGeH (ORCPT ); Thu, 10 Mar 2022 01:34:07 -0500 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14F4F381A5 for ; Wed, 9 Mar 2022 22:33:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646893987; x=1678429987; h=date:from:to:cc:subject:message-id:mime-version; bh=kf8BXuaXDVika6/ZALSU+NzaqKsW5XcznOhPEQh5sX8=; b=Sv4M1GlqK2W4jjYh4GJjI+K6WcYI8ZYyhCA88lpK1H5bJ2krAHECRV+I 0gknOuxoRah0COYietPH9Vo4Pc+lSbLz+bwugXq2OQT/3NsDs/wo6Ctvr 3T4WFJLaO9bSsBqDBrpaPKDZ/5+kkNSpITwSAGv8NhFHfVdJL/aSP1NVZ diAO5KGxhQmQFhEitZ5NexNuQUJyUxaLwOiflOMdK5CHKHBghePvH5iQo 60ArkOeuHNIGoF8d1GuEt04xZd/ae8s43aVSslnlLeFiICK++VsPHhSyB OYge9Ye97B+iz5U71a5WHXPxFPtHYA8y1ziOlZRC+Lidly2XgbEBVF8Oa g==; X-IronPort-AV: E=McAfee;i="6200,9189,10281"; a="255117557" X-IronPort-AV: E=Sophos;i="5.90,169,1643702400"; d="scan'208";a="255117557" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2022 22:32:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,169,1643702400"; d="scan'208";a="688562381" Received: from lkp-server02.sh.intel.com (HELO 89b41b6ae01c) ([10.239.97.151]) by fmsmga001.fm.intel.com with ESMTP; 09 Mar 2022 22:32:33 -0800 Received: from kbuild by 89b41b6ae01c with local (Exim 4.92) (envelope-from ) id 1nSCLg-0004Sz-UJ; Thu, 10 Mar 2022 06:32:32 +0000 Date: Thu, 10 Mar 2022 14:31:53 +0800 From: kernel test robot To: Saravana Kannan Cc: kbuild-all@lists.01.org, GNU/Weeb Mailing List , linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: [ammarfaizi2-block:google/android/kernel/common/android12-5.10-2021-12 1300/9999] drivers/base/core.c:1542:5: warning: no previous prototype for 'fw_devlink_relax_cycle' Message-ID: <202203101407.4WP0DiPE-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Saravana, FYI, the error/warning still remains. tree: https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android12-5.10-2021-12 head: 66c74c58ab38fb1f5edb12b8bace4cf5bbad2cfd commit: 1df699c140a778ed678d7d4b2fa8ffb2c62573e1 [1300/9999] UPSTREAM: driver core: Handle cycles in device links created by fw_devlink config: i386-tinyconfig (https://download.01.org/0day-ci/archive/20220310/202203101407.4WP0DiPE-lkp@intel.com/config) compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0 reproduce (this is a W=1 build): # https://github.com/ammarfaizi2/linux-block/commit/1df699c140a778ed678d7d4b2fa8ffb2c62573e1 git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block git fetch --no-tags ammarfaizi2-block google/android/kernel/common/android12-5.10-2021-12 git checkout 1df699c140a778ed678d7d4b2fa8ffb2c62573e1 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/base/ kernel/printk/ kernel/sched/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/base/core.c:1542:5: warning: no previous prototype for 'fw_devlink_relax_cycle' [-Wmissing-prototypes] 1542 | int fw_devlink_relax_cycle(struct device *con, void *sup) | ^~~~~~~~~~~~~~~~~~~~~~ vim +/fw_devlink_relax_cycle +1542 drivers/base/core.c 1527 1528 /** 1529 * fw_devlink_relax_cycle - Convert cyclic links to SYNC_STATE_ONLY links 1530 * @con: Device to check dependencies for. 1531 * @sup: Device to check against. 1532 * 1533 * Check if @sup depends on @con or any device dependent on it (its child or 1534 * its consumer etc). When such a cyclic dependency is found, convert all 1535 * device links created solely by fw_devlink into SYNC_STATE_ONLY device links. 1536 * This is the equivalent of doing fw_devlink=permissive just between the 1537 * devices in the cycle. We need to do this because, at this point, fw_devlink 1538 * can't tell which of these dependencies is not a real dependency. 1539 * 1540 * Return 1 if a cycle is found. Otherwise, return 0. 1541 */ > 1542 int fw_devlink_relax_cycle(struct device *con, void *sup) 1543 { 1544 struct device_link *link; 1545 int ret; 1546 1547 if (con == sup) 1548 return 1; 1549 1550 ret = device_for_each_child(con, sup, fw_devlink_relax_cycle); 1551 if (ret) 1552 return ret; 1553 1554 list_for_each_entry(link, &con->links.consumers, s_node) { 1555 if ((link->flags & ~DL_FLAG_INFERRED) == 1556 (DL_FLAG_SYNC_STATE_ONLY | DL_FLAG_MANAGED)) 1557 continue; 1558 1559 if (!fw_devlink_relax_cycle(link->consumer, sup)) 1560 continue; 1561 1562 ret = 1; 1563 1564 if (!(link->flags & DL_FLAG_INFERRED)) 1565 continue; 1566 1567 pm_runtime_drop_link(link); 1568 link->flags = DL_FLAG_MANAGED | FW_DEVLINK_FLAGS_PERMISSIVE; 1569 dev_dbg(link->consumer, "Relaxing link with %s\n", 1570 dev_name(link->supplier)); 1571 } 1572 return ret; 1573 } 1574 --- 0-DAY CI Kernel Test Service https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org