Re: [PATCH 5.10 38/58] KVM: arm64: Allow indirect vectors to be used without SPECTRE_V3A

Greg Kroah-Hartman
2022-03-15T12:29:52Z

On Tue, Mar 15, 2022 at 12:20:31PM +0000, James Morse wrote:
> Hi guys,
>
> On 3/11/22 6:42 AM, Greg Kroah-Hartman wrote:
> > On Fri, Mar 11, 2022 at 12:48:59AM +0100, Pavel Machek wrote:
> > > What is going on here?
> > >
> > > > commit 5bdf3437603d4af87f9c7f424b0c8aeed2420745 upstream.
> > >
> > > Upstream commit 5bdf is very different from this. In particular,
> > >
> > > > arch/arm64/kvm/hyp/smccc_wa.S | 66 +++++++++++++++++++++++++++++++++++++++
> > >
> > > I can't find smccc_wa.S, neither in mainline, nor in -next. And it
> > > looks buggy. I suspect loop_k24 should loop 24 times, but it does 8
> > > loops AFAICT. Same problem with loop_k32.
>
> Yup, that's a bug. Thanks for spotting it!
> I'll post a replacement for this patch.

That's going to be hard as this is now in a merged tree :(

Can you just send a fixup?

thanks,

greg k-h