From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9882C433EF for ; Thu, 10 Mar 2022 15:14:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343631AbiCJPPN (ORCPT ); Thu, 10 Mar 2022 10:15:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344397AbiCJPOd (ORCPT ); Thu, 10 Mar 2022 10:14:33 -0500 Received: from smtp.tom.com (smtprz02.163.net [106.3.154.235]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E267649F0C for ; Thu, 10 Mar 2022 07:13:30 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by vip-app02.163.net (Postfix) with ESMTP id 3E9E14400AE for ; Thu, 10 Mar 2022 23:13:29 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tom.com; s=mail; t=1646925209; bh=doCJDH1zWUod9q6whn+dh+jk6wzxYxXQrH/FUdQRXcc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2TK1xzC8QEtsTXUKvvNDWk8LAPMiL+SZH9ZCrS2kiSHVJmWA4THmOif7PTv5piFuM 8N9ooCVqw1JafDRAeWEEe19Mo7FuYroF7rJUxqh7lJ3d1gU2D+hcRM35WqM+AsabZ6 nadKeQAxpMpaDvsXdzbyyGi5K8j+82g8xf9Fr92c= Received: from localhost (HELO smtp.tom.com) ([127.0.0.1]) by localhost (TOM SMTP Server) with SMTP ID 846290663 for ; Thu, 10 Mar 2022 23:13:29 +0800 (CST) X-Virus-Scanned: Debian amavisd-new at mxtest.tom.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tom.com; s=mail; t=1646925209; bh=doCJDH1zWUod9q6whn+dh+jk6wzxYxXQrH/FUdQRXcc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2TK1xzC8QEtsTXUKvvNDWk8LAPMiL+SZH9ZCrS2kiSHVJmWA4THmOif7PTv5piFuM 8N9ooCVqw1JafDRAeWEEe19Mo7FuYroF7rJUxqh7lJ3d1gU2D+hcRM35WqM+AsabZ6 nadKeQAxpMpaDvsXdzbyyGi5K8j+82g8xf9Fr92c= Received: from localhost (unknown [101.93.196.13]) by antispamvip.163.net (Postfix) with ESMTPA id 9669215414BB; Thu, 10 Mar 2022 23:13:26 +0800 (CST) Date: Thu, 10 Mar 2022 23:13:25 +0800 From: Mingbao Sun To: Christoph Hellwig Cc: Keith Busch , Jens Axboe , Sagi Grimberg , Chaitanya Kulkarni , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, tyler.sun@dell.com, ping.gan@dell.com, yanxiu.cai@dell.com, libin.zhang@dell.com, ao.sun@dell.com Subject: Re: [PATCH v2 1/2] nvmet-tcp: support specifying the congestion-control Message-ID: <20220310231325.00000232@tom.com> In-Reply-To: <20220310142034.GA1038@lst.de> References: <20220309053711.2561-1-sunmingbao@tom.com> <20220309061541.GB31316@lst.de> <20220309175203.00006ee2@tom.com> <20220310083811.GA26953@lst.de> <20220310190636.00001695@tom.com> <20220310142034.GA1038@lst.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Mar 2022 15:20:34 +0100 Christoph Hellwig wrote: > On Thu, Mar 10, 2022 at 07:06:36PM +0800, Mingbao Sun wrote: > > I feel it=E2=80=99s not proper to create a sysfs entry for each socket. > > And for those sockets that do not have the exception of > > congestion-control, it=E2=80=99s merely a waste of resources. > >=20 > > Also, since these sockets generate and die dynamically, the info > > exported via fs may even do not have the opportunity to be seen by > > the user. > >=20 > > Anyway, if you insist that the checking and warning here is not proper, > > I can remove it. =20 >=20 > Something that can happen during normal operation is per definition no > something that should be warned about. Got. Will remove this checking and warning in the next version.