From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D280C433F5 for ; Fri, 11 Mar 2022 15:20:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348795AbiCKPVN (ORCPT ); Fri, 11 Mar 2022 10:21:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348754AbiCKPVL (ORCPT ); Fri, 11 Mar 2022 10:21:11 -0500 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94FF31C65FC; Fri, 11 Mar 2022 07:20:07 -0800 (PST) Received: by mail-ej1-x631.google.com with SMTP id bg10so19819734ejb.4; Fri, 11 Mar 2022 07:20:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ye4poFlqimWme3JzRC10+EfxoIGwS7g7DYQgKuH9c7s=; b=WPfrtv5uH1mp04VPqGW1UACEcS8/Uibpoc8lgWplk5z5WiOeesMQIKqwpEqY2Wd4k7 StES0EC7YievGeobAdRKTeK6Wj86U6I/YuMWljBvtlHoaQOqy5WHsm/pruhV+stmzXB4 Ie/G3SIZh7qTVDdax32QK1nxTmFuUabeFvYSYX8hph2DLti5zcKJFrCCV60lf/QsVQrP OwMMHAsK7+ypv6/DC8FtCGARi7QaEI0WOXrLsRLVsECMeE7b21zPEGnHBxj+vL8Ce2Hh FidQ9U81d4U+yJ7BAJvlID6dyPA9CfyxBRTMDKWqiIlIqfqIvHXcUQVC9LvXDxNuur9A hz+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ye4poFlqimWme3JzRC10+EfxoIGwS7g7DYQgKuH9c7s=; b=iqkGFQRL3fqiUBn5eFKqN+fqj3WVjF5aS7/ApsQaFtkvQfrTnXAlvPQ+iYOuoaUXVn 6V6REnS0t7BHkmZCsB3qCSx0DyJDxlS9l1Ol02JqIXCIHIP04HxdnMqaG2rnGUZ//j3K 0FN7aHRMz0z9xDuSpZiF+xiRGWZhwDXkCXeVbUEygcDYaqsv0nxBGGeCSqW6jq5cgW9Y QyM5lPNnY/+n0IAzOrv11SHbhY+64Qw7MV1rvtg8iwWH0TUXDCF2aYAtCQsxuOAgubgP Zs7jq4tu+ttZkW/Rsak4PQccESdSzHDfUn8ZjPSGGT4ARsNBs5DVGVyi6DJVQB24/rAW yG/w== X-Gm-Message-State: AOAM530/RN+W/rbYVaxXBHOVQBhKxix1YLX2Xt3sMexYiRk/FHpX++Xw srCoteeM/Zf8EX8ihOIcjqY= X-Google-Smtp-Source: ABdhPJxZslcDJOqMzIDI4ATQjHKokD7W13eryZ/e5fR6It/m/aCm9jxc/N39whx9wJ/6L7pi9IBUJA== X-Received: by 2002:a17:906:3913:b0:6da:b2dc:2278 with SMTP id f19-20020a170906391300b006dab2dc2278mr8841816eje.419.1647012005797; Fri, 11 Mar 2022 07:20:05 -0800 (PST) Received: from anparri (host-79-27-67-85.retail.telecomitalia.it. [79.27.67.85]) by smtp.gmail.com with ESMTPSA id bn14-20020a170906c0ce00b006c5ef0494besm3021225ejb.86.2022.03.11.07.20.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Mar 2022 07:20:05 -0800 (PST) Date: Fri, 11 Mar 2022 16:19:57 +0100 From: Andrea Parri To: "Michael Kelley (LINUX)" Cc: KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Tianyu Lan , Long Li , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] Drivers: hv: vmbus: Fix initialization of device object in vmbus_device_register() Message-ID: <20220311151957.GA39518@anparri> References: <20220311133738.38649-1-parri.andrea@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > --- > > drivers/hv/vmbus_drv.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c > > index 12a2b37e87f30..65db5048b1763 100644 > > --- a/drivers/hv/vmbus_drv.c > > +++ b/drivers/hv/vmbus_drv.c > > @@ -2097,6 +2097,9 @@ int vmbus_device_register(struct hv_device > > *child_device_obj) > > child_device_obj->device.parent = &hv_acpi_dev->dev; > > child_device_obj->device.release = vmbus_device_release; > > > > + child_device_obj->device.dma_parms = &child_device_obj->dma_parms; > > + child_device_obj->device.dma_mask = &child_device_obj->dma_mask; > > + > > /* > > * Register with the LDM. This will kick off the driver/device > > * binding...which will eventually call vmbus_match() and vmbus_probe() > > @@ -2122,8 +2125,6 @@ int vmbus_device_register(struct hv_device > > *child_device_obj) > > } > > hv_debug_add_dev_dir(child_device_obj); > > > > - child_device_obj->device.dma_parms = &child_device_obj->dma_parms; > > - child_device_obj->device.dma_mask = &child_device_obj->dma_mask; > > dma_set_mask(&child_device_obj->device, DMA_BIT_MASK(64)); > > Is there any reason to not move dma_set_mask() as well? That call is > closely related to the previous two lines, so it is unexpected to have > them separated. The only reason was "minimize diff"; sounds like I'll move it in v2. ;-) Thanks, Andrea