Re: [PATCH] gpio: ts4900: Fix comment formatting and grammar

Andy Shevchenko
2022-03-12T13:07:05Z

On Fri, Mar 11, 2022 at 8:20 PM Kris Bahnsen <kris@embeddedts.com> wrote:
>
> The issues were pointed out after the prior commit was applied

Missed period in the above sentence.

Otherwise LGTM,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Kris Bahnsen <kris@embeddedTS.com>
> ---
> drivers/gpio/gpio-ts4900.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ts4900.c b/drivers/gpio/gpio-ts4900.c
> index d918d2df4de2..ede605b8e098 100644
> --- a/drivers/gpio/gpio-ts4900.c
> +++ b/drivers/gpio/gpio-ts4900.c
> @@ -55,8 +55,9 @@ static int ts4900_gpio_direction_input(struct gpio_chip *chip,
> {
> struct ts4900_gpio_priv *priv = gpiochip_get_data(chip);
>
> - /* Only clear the OE bit here, requires a RMW. Prevents potential issue
> - * with OE and data getting to the physical pin at different times.
> + /*
> + * Only clear the OE bit here, requires a RMW. Prevents a potential issue
> + * with OE and DAT getting to the physical pin at different times.
> */
> return regmap_update_bits(priv->regmap, offset, TS4900_GPIO_OE, 0);
> }
> @@ -68,9 +69,10 @@ static int ts4900_gpio_direction_output(struct gpio_chip *chip,
> unsigned int reg;
> int ret;
>
> - /* If changing from an input to an output, we need to first set the
> - * proper data bit to what is requested and then set OE bit. This
> - * prevents a glitch that can occur on the IO line
> + /*
> + * If changing from an input to an output, we need to first set the
> + * GPIO's DAT bit to what is requested and then set the OE bit. This
> + * prevents a glitch that can occur on the IO line.
> */
> regmap_read(priv->regmap, offset, &reg);
> if (!(reg & TS4900_GPIO_OE)) {
> --
> 2.11.0
>

--
With Best Regards,
Andy Shevchenko