public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Hannes Reinecke <hare@suse.de>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: [PATCH] crypto,fs: fix noderef.cocci warnings
Date: Mon, 14 Mar 2022 03:52:21 +0800	[thread overview]
Message-ID: <20220313195221.GA82451@f7536ca88abf> (raw)
In-Reply-To: <202203140317.0on9b3HF-lkp@intel.com>

From: kernel test robot <lkp@intel.com>

crypto/hkdf.c:94:25-31: ERROR: application of sizeof to pointer

 sizeof when applied to a pointer typed expression gives the size of
 the pointer

Generated by: scripts/coccinelle/misc/noderef.cocci

Fixes: ea4c6fc32e5e ("crypto,fs: Separate out hkdf_extract() and hkdf_expand()")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git tls-upcall.v4
head:   d2416ecdb6b03fc2e4aa40b20cdf919322713224
commit: ea4c6fc32e5e02a1e4c841f462c3a931b8838f33 [118/156] crypto,fs: Separate out hkdf_extract() and hkdf_expand()
:::::: branch date: 3 days ago
:::::: commit date: 5 days ago

 crypto/hkdf.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/crypto/hkdf.c
+++ b/crypto/hkdf.c
@@ -91,7 +91,7 @@ int hkdf_expand(struct crypto_shash *hma
 			if (err)
 				goto out;
 			memcpy(&okm[i], tmp, okmlen - i);
-			memzero_explicit(tmp, sizeof(tmp));
+			memzero_explicit(tmp, sizeof(*tmp));
 		} else {
 			err = crypto_shash_finup(desc, &counter, 1, &okm[i]);
 			if (err)

      reply	other threads:[~2022-03-13 19:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-13 20:00 [hare-scsi-devel:tls-upcall.v4 118/156] crypto/hkdf.c:94:25-31: ERROR: application of sizeof to pointer kernel test robot
2022-03-13 19:52 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220313195221.GA82451@f7536ca88abf \
    --to=lkp@intel.com \
    --cc=hare@suse.de \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox