public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Trevor Woerner <twoerner@gmail.com>
To: linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>
Cc: linux-serial@vger.kernel.org
Subject: [PATCH v2 1/3] serial: 8250_fintek: Finish support for the F81865
Date: Mon, 14 Mar 2022 08:18:56 -0400	[thread overview]
Message-ID: <20220314121856.10112-1-twoerner@gmail.com> (raw)

This driver only partially supports the F81865 device. The UART portions of
this SuperIO chip behave very similarly to the UART of the F81866, except
that the F81866 has 128-byte FIFOs whereas the F81865 has 16-byte FIFOs,
and the IRQ configuration is different. Therefore fill out the support for
the F81865 in the places where it is missing.

Tested at 1500000 baud on the iEi NANO-PV-D5251-R10 board.

Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
 drivers/tty/serial/8250/8250_fintek.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_fintek.c b/drivers/tty/serial/8250/8250_fintek.c
index 251f0018ae8c..47b15d2d9901 100644
--- a/drivers/tty/serial/8250/8250_fintek.c
+++ b/drivers/tty/serial/8250/8250_fintek.c
@@ -63,7 +63,12 @@
 #define F81216_LDN_HIGH	0x4
 
 /*
- * F81866/966 registers
+ * F81866/865/966 registers
+ *
+ * The UART portion of the F81865 functions very similarly to the UART
+ * portion of the F81866, so there's no need to duplicate all the #defines
+ * etc. The only differences are: the F81866 has 128-byte FIFOs whereas the
+ * F81865 has 16-byte FIFOs, and the IRQ configuration is different.
  *
  * The IRQ setting mode of F81866/966 is not the same with F81216 series.
  *	Level/Low: IRQ_MODE0:0, IRQ_MODE1:0
@@ -316,6 +321,7 @@ static void fintek_8250_set_termios(struct uart_port *port,
 		break;
 	case CHIP_ID_F81966:
 	case CHIP_ID_F81866:
+	case CHIP_ID_F81865:
 		reg = F81866_UART_CLK;
 		break;
 	default:
@@ -363,6 +369,7 @@ static void fintek_8250_set_termios_handler(struct uart_8250_port *uart)
 	case CHIP_ID_F81216H:
 	case CHIP_ID_F81966:
 	case CHIP_ID_F81866:
+	case CHIP_ID_F81865:
 		uart->port.set_termios = fintek_8250_set_termios;
 		break;
 
-- 
2.35.1.455.g1a4874565f


             reply	other threads:[~2022-03-14 12:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14 12:18 Trevor Woerner [this message]
2022-03-18 12:27 ` [PATCH v2 1/3] serial: 8250_fintek: Finish support for the F81865 Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220314121856.10112-1-twoerner@gmail.com \
    --to=twoerner@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox