* [PATCH] scsi: bsg: drop needless assignment in scsi_bsg_sg_io_fn()
@ 2022-03-15 5:53 Lukas Bulwahn
2022-03-15 6:29 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Lukas Bulwahn @ 2022-03-15 5:53 UTC (permalink / raw)
To: Christoph Hellwig, Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Commit ce70fd9a551a ("scsi: core: Remove the cmd field from struct
scsi_request") refactored scsi_bsg_sg_io_fn(), so that it does not
allocate directly and hence does not return -ENOMEM in its error case.
That makes a remaining assignment of -ENOMEM to the return variable
needless.
Drop this needless assignment in scsi_bsg_sg_io_fn().
No functional change. No change in resulting object code.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Christoph, please ack.
Martin, please pick this minor clean-up on your -next tree on top of the
commit above.
drivers/scsi/scsi_bsg.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/scsi_bsg.c b/drivers/scsi/scsi_bsg.c
index 8039c3c11a6e..96ee35256a16 100644
--- a/drivers/scsi/scsi_bsg.c
+++ b/drivers/scsi/scsi_bsg.c
@@ -31,7 +31,6 @@ static int scsi_bsg_sg_io_fn(struct request_queue *q, struct sg_io_v4 *hdr,
return PTR_ERR(rq);
rq->timeout = timeout;
- ret = -ENOMEM;
scmd = blk_mq_rq_to_pdu(rq);
scmd->cmd_len = hdr->request_len;
if (scmd->cmd_len > sizeof(scmd->cmnd)) {
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: bsg: drop needless assignment in scsi_bsg_sg_io_fn()
2022-03-15 5:53 [PATCH] scsi: bsg: drop needless assignment in scsi_bsg_sg_io_fn() Lukas Bulwahn
@ 2022-03-15 6:29 ` Christoph Hellwig
2022-03-15 18:05 ` Martin K. Petersen
2022-03-19 3:56 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2022-03-15 6:29 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Christoph Hellwig, Martin K . Petersen, linux-scsi,
kernel-janitors, linux-kernel
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: bsg: drop needless assignment in scsi_bsg_sg_io_fn()
2022-03-15 5:53 [PATCH] scsi: bsg: drop needless assignment in scsi_bsg_sg_io_fn() Lukas Bulwahn
2022-03-15 6:29 ` Christoph Hellwig
@ 2022-03-15 18:05 ` Martin K. Petersen
2022-03-19 3:56 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-03-15 18:05 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Christoph Hellwig, Martin K . Petersen, linux-scsi,
kernel-janitors, linux-kernel
Lukas,
> Commit ce70fd9a551a ("scsi: core: Remove the cmd field from struct
> scsi_request") refactored scsi_bsg_sg_io_fn(), so that it does not
> allocate directly and hence does not return -ENOMEM in its error case.
> That makes a remaining assignment of -ENOMEM to the return variable
> needless.
Applied to 5.18/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: bsg: drop needless assignment in scsi_bsg_sg_io_fn()
2022-03-15 5:53 [PATCH] scsi: bsg: drop needless assignment in scsi_bsg_sg_io_fn() Lukas Bulwahn
2022-03-15 6:29 ` Christoph Hellwig
2022-03-15 18:05 ` Martin K. Petersen
@ 2022-03-19 3:56 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-03-19 3:56 UTC (permalink / raw)
To: Christoph Hellwig, linux-scsi, Lukas Bulwahn
Cc: Martin K . Petersen, linux-kernel, kernel-janitors
On Tue, 15 Mar 2022 06:53:25 +0100, Lukas Bulwahn wrote:
> Commit ce70fd9a551a ("scsi: core: Remove the cmd field from struct
> scsi_request") refactored scsi_bsg_sg_io_fn(), so that it does not
> allocate directly and hence does not return -ENOMEM in its error case.
> That makes a remaining assignment of -ENOMEM to the return variable
> needless.
>
> Drop this needless assignment in scsi_bsg_sg_io_fn().
>
> [...]
Applied to 5.18/scsi-queue, thanks!
[1/1] scsi: bsg: drop needless assignment in scsi_bsg_sg_io_fn()
https://git.kernel.org/mkp/scsi/c/dc155e1acb18
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-19 3:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-15 5:53 [PATCH] scsi: bsg: drop needless assignment in scsi_bsg_sg_io_fn() Lukas Bulwahn
2022-03-15 6:29 ` Christoph Hellwig
2022-03-15 18:05 ` Martin K. Petersen
2022-03-19 3:56 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox