Re: [PATCH v0] pata_parport: add driver (PARIDE replacement)

Christoph Hellwig
2022-03-15T08:23:11Z

On Sat, Mar 12, 2022 at 12:21:55PM +0100, Ondrej Zary wrote:
> > Here, I am assuming that block/paride is the core code used by both
> > PARIDE and PATA_PARPORT. Not sure what PARPORT_PC does nor what its
> > dependency on block/paride code is.
>
> There's no common core in block/paride. The block/paride/Makefile says:
> obj-$(CONFIG_PARIDE) += paride.o
> obj-$(CONFIG_PARIDE_ATEN) += aten.o
> obj-$(CONFIG_PARIDE_...other protocol drivers
>
> So if PARIDE and all protocol drivers are disabled, nothing is compiled there.

Yeah. The pattern of unconditionally descending into a subdirectory
isn't entirely uncommon. I think this is perfectly fine here.