* [PATCH] nvme-pci: disable write zeros support on specific SSDs
@ 2022-03-15 10:47 Mark Hsieh
2022-03-15 12:06 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: Mark Hsieh @ 2022-03-15 10:47 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-nvme, sagi, hch, axboe, kbusch, Mark_Hsieh, Mark Hsieh
Like commit 5611ec2b9814 ("nvme-pci: prevent SK hynix PC400 from using
Write Zeroes command"), Micron has the same issue:
[ 6305.633887] blk_update_request: operation not supported error, dev
nvme0n1, sector 340812032 op 0x9:(WRITE_ZEROES) flags 0x0 phys_seg 0 prio class 0
So also disable Write Zeroes command on Micron.
Signed-off-by: Mark Hsieh <mark_hsieh@wistron.corp-partner.google.com>
Change-Id: Ic6ebfe141702d1869490bbf210627055b5b4d80f
---
drivers/nvme/host/pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index a7a502a5b2b5..68745e1d7b6a 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3245,6 +3245,8 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
{ PCI_DEVICE(0x2646, 0x500d), /* Kingston OM3PDP3256B-AH 256G */
.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+ { PCI_DEVICE(0x1344, 0x5411), /* Micron 2450 MTFDKCD256TFK 256G */
+ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
{ PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
{ PCI_DEVICE(0x2646, 0x2263), /* KINGSTON A2000 NVMe SSD */
.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] nvme-pci: disable write zeros support on specific SSDs
2022-03-15 10:47 [PATCH] nvme-pci: disable write zeros support on specific SSDs Mark Hsieh
@ 2022-03-15 12:06 ` Christoph Hellwig
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2022-03-15 12:06 UTC (permalink / raw)
To: Mark Hsieh
Cc: linux-kernel, linux-nvme, sagi, hch, axboe, kbusch, Mark_Hsieh,
Walt Hubis
On Tue, Mar 15, 2022 at 06:47:02PM +0800, Mark Hsieh wrote:
> Like commit 5611ec2b9814 ("nvme-pci: prevent SK hynix PC400 from using
> Write Zeroes command"), Micron has the same issue:
> [ 6305.633887] blk_update_request: operation not supported error, dev
> nvme0n1, sector 340812032 op 0x9:(WRITE_ZEROES) flags 0x0 phys_seg 0 prio class 0
>
> So also disable Write Zeroes command on Micron.
>
> Signed-off-by: Mark Hsieh <mark_hsieh@wistron.corp-partner.google.com>
> Change-Id: Ic6ebfe141702d1869490bbf210627055b5b4d80f
Please drop these strange Change-Id tags. But more importantly
something seems really broken here if the device claims to support
Write Zeroes but then doesn't claims it is not supported.
Can you see if this only happens with some I/O size? With our without
the nounmap flag? Does the device report non-MDTS command limits?
> ---
> drivers/nvme/host/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index a7a502a5b2b5..68745e1d7b6a 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3245,6 +3245,8 @@ static const struct pci_device_id nvme_id_table[] = {
> .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
> { PCI_DEVICE(0x2646, 0x500d), /* Kingston OM3PDP3256B-AH 256G */
> .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
> + { PCI_DEVICE(0x1344, 0x5411), /* Micron 2450 MTFDKCD256TFK 256G */
> + .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
> { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
> { PCI_DEVICE(0x2646, 0x2263), /* KINGSTON A2000 NVMe SSD */
> .driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
> --
> 2.17.1
---end quoted text---
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] nvme-pci: disable write zeros support on specific SSDs
@ 2020-11-26 3:19 Mark Hsieh
0 siblings, 0 replies; 5+ messages in thread
From: Mark Hsieh @ 2020-11-26 3:19 UTC (permalink / raw)
To: kbusch; +Cc: linux-kernel, mark_hsieh, Mark Hsieh
Like commit 5611ec2b9814 ("nvme-pci: prevent SK hynix PC400 from using
Write Zeroes command"), Samsung, Phison and Kingston have the same issue:
[ 6305.633887] blk_update_request: operation not supported error, dev nvme0n1, sector 340812032 op 0x9:(WRITE_ZEROES) flags 0x0 phys_seg 0 prio class 0
So also disable Write Zeroes command on Samsung, Phison and Kingston.
Signed-off-by: Mark Hsieh <mark_hsieh@wistron.corp-partner.google.com>
---
drivers/nvme/host/pci.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 0578ff253c47..ceedb5dcb54c 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3202,6 +3202,12 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
{ PCI_DEVICE(0x15b7, 0x2001), /* Sandisk Skyhawk */
.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+ { PCI_DEVICE(0x144d, 0xa809), /* Samsung 128HBHQ and 256HAJD */
+ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+ { PCI_DEVICE(0x1987, 0x5013), /* Phison PS5013 E13 */
+ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+ { PCI_DEVICE(0x2646, 0x500d), /* Kingston OM3PDP3256B-AH 256G */
+ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
{ PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001),
.driver_data = NVME_QUIRK_SINGLE_VECTOR },
{ PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] nvme-pci: disable write zeros support on specific SSDs
@ 2020-11-25 14:20 Mark Hsieh
0 siblings, 0 replies; 5+ messages in thread
From: Mark Hsieh @ 2020-11-25 14:20 UTC (permalink / raw)
To: paulburton
Cc: ralf, jhogan, christian, linux-kernel, mark_hsieh, linux-mips,
Mark Hsieh
Like commit 5611ec2b9814 ("nvme-pci: prevent SK hynix PC400 from using
Write Zeroes command"), Samsung, Phison and Kingston have the same issue:
[ 6305.633887] blk_update_request: operation not supported error, dev nvme0n1, sector 340812032 op 0x9:(WRITE_ZEROES) flags 0x0 phys_seg 0 prio class 0
So also disable Write Zeroes command on Samsung, Phison and Kingston.
Signed-off-by: Mark Hsieh <mark_hsieh@wistron.corp-partner.google.com>
---
drivers/nvme/host/pci.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 0578ff253c47..ceedb5dcb54c 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3202,6 +3202,12 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
{ PCI_DEVICE(0x15b7, 0x2001), /* Sandisk Skyhawk */
.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+ { PCI_DEVICE(0x144d, 0xa809), /* Samsung 128HBHQ and 256HAJD */
+ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+ { PCI_DEVICE(0x1987, 0x5013), /* Phison PS5013 E13 */
+ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+ { PCI_DEVICE(0x2646, 0x500d), /* Kingston OM3PDP3256B-AH 256G */
+ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
{ PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001),
.driver_data = NVME_QUIRK_SINGLE_VECTOR },
{ PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] nvme-pci: disable write zeros support on specific SSDs
@ 2020-11-25 11:41 Mark Hsieh
0 siblings, 0 replies; 5+ messages in thread
From: Mark Hsieh @ 2020-11-25 11:41 UTC (permalink / raw)
To: linux-kernel; +Cc: mark_hsieh, linux-mips, Mark Hsieh
Like commit 5611ec2b9814 ("nvme-pci: prevent SK hynix PC400 from using
Write Zeroes command"), Samsung, Phison and Kingston have the same issue:
[ 6305.633887] blk_update_request: operation not supported error, dev nvme0n1, sector 340812032 op 0x9:(WRITE_ZEROES) flags 0x0 phys_seg 0 prio class 0
So also disable Write Zeroes command on Samsung, Phison and Kingston.
Signed-off-by: Mark Hsieh <mark_hsieh@wistron.corp-partner.google.com>
---
drivers/nvme/host/pci.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 0578ff253c47..ceedb5dcb54c 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3202,6 +3202,12 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
{ PCI_DEVICE(0x15b7, 0x2001), /* Sandisk Skyhawk */
.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+ { PCI_DEVICE(0x144d, 0xa809), /* Samsung 128HBHQ and 256HAJD */
+ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+ { PCI_DEVICE(0x1987, 0x5013), /* Phison PS5013 E13 */
+ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+ { PCI_DEVICE(0x2646, 0x500d), /* Kingston OM3PDP3256B-AH 256G */
+ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
{ PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001),
.driver_data = NVME_QUIRK_SINGLE_VECTOR },
{ PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-03-15 12:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-15 10:47 [PATCH] nvme-pci: disable write zeros support on specific SSDs Mark Hsieh
2022-03-15 12:06 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2020-11-26 3:19 Mark Hsieh
2020-11-25 14:20 Mark Hsieh
2020-11-25 11:41 Mark Hsieh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox