RE: [PATCH v2 4/8] iommu/vt-d: Use device_pasid attach op for RID2PASID

Tian, Kevin
2022-03-16T07:54:51Z

> From: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Sent: Tuesday, March 15, 2022 1:07 PM
>
> With the availability of a generic device-PASID-domain attachment API,
> there's no need to special case RID2PASID. Use the API to replace
> duplicated code.
>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> ---
> drivers/iommu/intel/iommu.c | 18 ++----------------
> 1 file changed, 2 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index 9267194eaed3..f832b7599d21 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -1683,9 +1683,6 @@ static void domain_flush_piotlb(struct
> intel_iommu *iommu,
> qi_flush_piotlb(iommu, did, domain->default_pasid,
> addr, npages, ih);
>
> - if (!list_empty(&domain->devices))
> - qi_flush_piotlb(iommu, did, PASID_RID2PASID, addr, npages,
> ih);
> -

this should be rebased on top of Baolu's "iommu cleanup and refactoring"
series which has removed the entire domain_flush_piotlb().

Thanks
Kevin