RE: [PATCH v2 3/8] iommu/vt-d: Implement device_pasid domain attach ops

Tian, Kevin
2022-03-16T07:39:59Z

> From: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Sent: Tuesday, March 15, 2022 1:07 PM
> +static int intel_iommu_attach_dev_pasid(struct iommu_domain *domain,
> + struct device *dev, ioasid_t pasid)
> +{
> + struct dmar_domain *dmar_domain = to_dmar_domain(domain);
> + struct device_domain_info *info = get_domain_info(dev);
> + struct intel_iommu *iommu = info->iommu;
> + struct pasid_info *pinfo;
> + unsigned long flags;
> + int ret = 0;
> + void *entry;
> +
> + if (!info)
> + return -ENODEV;

btw this interface only works in scalable mode. Lack of a check to
return error on legacy mode here.

Thanks
Kevin