Re: [PATCH AUTOSEL 5.10 10/12] gpio: Revert regression in sysfs-gpio (gpiolib.c)

Sasha Levin
2022-03-16T16:40:35Z

On Wed, Mar 16, 2022 at 05:06:47PM +0100, Linus Walleij wrote:
>On Wed, Mar 16, 2022 at 3:17 PM Sasha Levin <sashal@kernel.org> wrote:
>
>> From: Marcelo Roberto Jimenez <marcelo.jimenez@gmail.com>
>>
>> [ Upstream commit fc328a7d1fcce263db0b046917a66f3aa6e68719 ]
>>
>> Some GPIO lines have stopped working after the patch
>> commit 2ab73c6d8323f ("gpio: Support GPIO controllers without pin-ranges")
>>
>> And this has supposedly been fixed in the following patches
>> commit 89ad556b7f96a ("gpio: Avoid using pin ranges with !PINCTRL")
>> commit 6dbbf84603961 ("gpiolib: Don't free if pin ranges are not defined")
>>
>> But an erratic behavior where some GPIO lines work while others do not work
>> has been introduced.
>>
>> This patch reverts those changes so that the sysfs-gpio interface works
>> properly again.
>>
>> Signed-off-by: Marcelo Roberto Jimenez <marcelo.jimenez@gmail.com>
>> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>
>I think you should not apply this for stable, because we will revert the revert.

Okay, I'll give it a week to soak and if the revert is in by then I can
just pick it too for the sake of completeness.

--
Thanks,
Sasha