public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@linaro.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: tglx@linutronix.de, maz@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] irq/qcom-mpm: Fix build error without MAILBOX
Date: Thu, 17 Mar 2022 21:59:17 +0800	[thread overview]
Message-ID: <20220317135917.GA360113@dragon> (raw)
In-Reply-To: <20220317131956.30004-1-yuehaibing@huawei.com>

On Thu, Mar 17, 2022 at 09:19:56PM +0800, YueHaibing wrote:
> If MAILBOX is n, building fails:
> 
> drivers/irqchip/irq-qcom-mpm.o: In function `mpm_pd_power_off':
> irq-qcom-mpm.c:(.text+0x174): undefined reference to `mbox_send_message'
> irq-qcom-mpm.c:(.text+0x174): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `mbox_send_message'
> 
> Make QCOM_MPM depends on MAILBOX to fix this.
> 
> Fixes: a6199bb514d8 ("irqchip: Add Qualcomm MPM controller driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Shawn Guo <shawn.guo@linaro.org>

> ---
>  drivers/irqchip/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 680d2fcf2686..15edb9a6fcae 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -433,6 +433,7 @@ config QCOM_PDC
>  config QCOM_MPM
>  	tristate "QCOM MPM"
>  	depends on ARCH_QCOM
> +	depends on MAILBOX
>  	select IRQ_DOMAIN_HIERARCHY
>  	help
>  	  MSM Power Manager driver to manage and configure wakeup
> -- 
> 2.17.1
> 

  reply	other threads:[~2022-03-17 13:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-17 13:19 [PATCH -next] irq/qcom-mpm: Fix build error without MAILBOX YueHaibing
2022-03-17 13:59 ` Shawn Guo [this message]
2022-03-17 15:27   ` Marc Zyngier
2022-03-17 15:33 ` [irqchip: irq/irqchip-next] " irqchip-bot for YueHaibing
2022-04-05 15:40 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for YueHaibing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220317135917.GA360113@dragon \
    --to=shawn.guo@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox