From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96B92C433F5 for ; Thu, 17 Mar 2022 21:19:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230243AbiCQVUj (ORCPT ); Thu, 17 Mar 2022 17:20:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230135AbiCQVUe (ORCPT ); Thu, 17 Mar 2022 17:20:34 -0400 Received: from mail-pg1-x54a.google.com (mail-pg1-x54a.google.com [IPv6:2607:f8b0:4864:20::54a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EADBEB2455 for ; Thu, 17 Mar 2022 14:19:16 -0700 (PDT) Received: by mail-pg1-x54a.google.com with SMTP id b18-20020a63d812000000b0037e1aa59c0bso2312030pgh.12 for ; Thu, 17 Mar 2022 14:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=6mHysSGkjSaV0ili798Q1zLL9ynUJ9JmihmTcdCLIZY=; b=kgTRMhvOjKo0YDi1oWQ8YuJ3ZeMPo74qt+/vjGdCcuqs8dkrP0TRKHe74cxBTHRisY pXpC7Ow+2tv6+LH3Y4J+kRigvMhRBwP34m3TIOywj5vMh3PHyuS2pozWWwFAF+JxmyQI ijSEtzxiCCln73+qzuFQho1qJyA+9K7PlXH2aic3sOO5/pXWtBiwYCpg7UtF2Nc/mZ0y leTXS0J1RZwoak/k4U9aNUICFCK2CU74Zziu/oRs7R4IMrbpMQExf1frRcDqN5tTsem9 7Y9xQ2+RG8tgUfvE4x3Xa2sLU0ccGllxOI/YzO8blwRuY/8ZXvt3XFGf8gf/N8V/mUXi VhHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=6mHysSGkjSaV0ili798Q1zLL9ynUJ9JmihmTcdCLIZY=; b=jYknUa3FcELtmKVMWrBpchRhk3ef5gQPddJ2h23jkwmOZ1QlOY8cKttrrPnHiLDM+t 8MOFIfq3caoz17MV3oFFmXzWNfH2O+J9uj1kALURlD/HmFakwbOpAhFcTaD/j4Qjrfl7 uBMFUT4XLYJGFiS2JaA+fOO8evulV49230ydwKHDh93ALYMgfLDdpZzRypHEulZqTJz0 HHdcJiANO8Ad6CBC1rtNWKDgTXOFI3Dkw7qaMUmpghj5uW6eV8K4PI7sNXslX2Q9qRIQ c9Z9QK+y77bMllGyCER0FoaluvZPEr9vu6s79WfKVTT7+byj4NAnoXvCDscYWkN/IbjI 7MbA== X-Gm-Message-State: AOAM532vxw346IBpTH7AfpRALLRotHNiB4MRMgzYmVtrHaCtPHHsSp4e Zcrg5QEiK7orfn63YjzW7WnEE0mSUHk= X-Google-Smtp-Source: ABdhPJzRlMtFf9+BfW4ekzaU3Vlw86V5D1cZQ96eDB6kmJFiiAOOAjp/f1ObJsH6I7e0TQxtVo1VhFUhRlE= X-Received: from pgonda1.kir.corp.google.com ([2620:15c:29:203:ef70:31aa:2364:9dda]) (user=pgonda job=sendgmr) by 2002:a17:902:e74f:b0:151:c20b:5f39 with SMTP id p15-20020a170902e74f00b00151c20b5f39mr6866669plf.43.1647551956388; Thu, 17 Mar 2022 14:19:16 -0700 (PDT) Date: Thu, 17 Mar 2022 14:19:13 -0700 Message-Id: <20220317211913.1397427-1-pgonda@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.35.1.894.gb6a874cedc-goog Subject: [PATCH] x86/sev-es: Replace open-coded hlt-loop with sev_es_terminate() From: Peter Gonda To: x86@kernel.org Cc: Peter Gonda , Borislav Petkov , Tom Lendacky , Brijesh Singh , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace the hlt loop in handle_vc_boot_ghcb() with an sev_es_terminate(). The hlt gives the system no indication the guest is unhappy. The termination request will signal there was an error during VC handling during boot. Cc: Borislav Petkov Cc: Tom Lendacky Cc: Brijesh Singh Cc: Joerg Roedel Cc: x86@kernel.org Cc: kvm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Peter Gonda --- arch/x86/kernel/sev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c index e6d316a01fdd..ae87fbf27724 100644 --- a/arch/x86/kernel/sev.c +++ b/arch/x86/kernel/sev.c @@ -1425,6 +1425,5 @@ bool __init handle_vc_boot_ghcb(struct pt_regs *regs) fail: show_regs(regs); - while (true) - halt(); + sev_es_terminate(GHCB_SEV_ES_GEN_REQ); } -- 2.35.1.894.gb6a874cedc-goog