From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF528C433EF for ; Fri, 18 Mar 2022 08:42:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233893AbiCRInr (ORCPT ); Fri, 18 Mar 2022 04:43:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233845AbiCRInn (ORCPT ); Fri, 18 Mar 2022 04:43:43 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 55B7C17B880; Fri, 18 Mar 2022 01:42:24 -0700 (PDT) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1nV8Bh-0005A4-00; Fri, 18 Mar 2022 09:42:21 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id A495DC2E3B; Fri, 18 Mar 2022 09:42:07 +0100 (CET) Date: Fri, 18 Mar 2022 09:42:07 +0100 From: Thomas Bogendoerfer To: Krzysztof Kozlowski Cc: Paul Cercueil , Rob Herring , Krzysztof Kozlowski , linux-mips@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: ingenic: correct unit node address Message-ID: <20220318084207.GA6652@alpha.franken.de> References: <20220317115259.448868-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220317115259.448868-1-krzysztof.kozlowski@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 17, 2022 at 12:52:59PM +0100, Krzysztof Kozlowski wrote: > Unit node addresses should not have leading 0x: > > Warning (unit_address_format): /nemc@13410000/efuse@d0/eth-mac-addr@0x22: unit name should not have leading "0x" > > Signed-off-by: Krzysztof Kozlowski > --- > arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi > index 3f9ea47a10cd..b998301f179c 100644 > --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi > +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi > @@ -510,7 +510,7 @@ efuse: efuse@d0 { > #address-cells = <1>; > #size-cells = <1>; > > - eth0_addr: eth-mac-addr@0x22 { > + eth0_addr: eth-mac-addr@22 { > reg = <0x22 0x6>; > }; > }; > -- > 2.32.0 applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]