Re: [PATCH v2 14/16] dt-bindings: clock: Convert qcom,krait-cc to yaml

Krzysztof Kozlowski
2022-03-20T12:09:51Z

On 18/03/2022 17:08, Ansuel Smith wrote:
> Convert qcom,krait-cc to yaml and add missing l2 clocks and names
> definiton.

lang typo.

>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> .../bindings/clock/qcom,krait-cc.txt | 34 ----------
> .../bindings/clock/qcom,krait-cc.yaml | 63 +++++++++++++++++++
> 2 files changed, 63 insertions(+), 34 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/qcom,krait-cc.txt
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,krait-cc.txt b/Documentation/devicetree/bindings/clock/qcom,krait-cc.txt
> deleted file mode 100644
> index 030ba60dab08..000000000000
> --- a/Documentation/devicetree/bindings/clock/qcom,krait-cc.txt
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -Krait Clock Controller
> -
> -PROPERTIES
> -
> -- compatible:
> - Usage: required
> - Value type: <string>
> - Definition: must be one of:
> - "qcom,krait-cc-v1"
> - "qcom,krait-cc-v2"
> -
> -- #clock-cells:
> - Usage: required
> - Value type: <u32>
> - Definition: must be 1
> -
> -- clocks:
> - Usage: required
> - Value type: <prop-encoded-array>
> - Definition: reference to the clock parents of hfpll, secondary muxes.
> -
> -- clock-names:
> - Usage: required
> - Value type: <stringlist>
> - Definition: must be "hfpll0", "hfpll1", "acpu0_aux", "acpu1_aux", "qsb".
> -
> -Example:
> -
> - kraitcc: clock-controller {
> - compatible = "qcom,krait-cc-v1";
> - clocks = <&hfpll0>, <&hfpll1>, <&acpu0_aux>, <&acpu1_aux>, <qsb>;
> - clock-names = "hfpll0", "hfpll1", "acpu0_aux", "acpu1_aux", "qsb";
> - #clock-cells = <1>;
> - };
> diff --git a/Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml b/Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml
> new file mode 100644
> index 000000000000..f89b70ab01ae
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,krait-cc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Krait Clock Controller
> +
> +maintainers:
> + - Ansuel Smith <ansuelsmth@gmail.com>
> +
> +description: |
> + Qualcomm Krait Clock Controller used to correctly scale the CPU and the L2
> + rates.
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,krait-cc-v1
> + - qcom,krait-cc-v2
> +
> + clocks:
> + items:
> + - description: phandle to hfpll for CPU0 mux
> + - description: phandle to hfpll for CPU1 mux
> + - description: phandle to hfpll for L2 mux
> + - description: phandle to CPU0 aux clock
> + - description: phandle to CPU1 aux clock
> + - description: phandle to L2 aux clock
> + - description: phandle to QSB fixed clk

None of these were in original bindings, original DTS (because it does
not exist), original driver. Therefore you do not need to change
bindings during conversion.

I propose to add them in second commit with explanation why do you add them.

Best regards,
Krzysztof