From: Nam Cao <namcaov@gmail.com>
To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Cc: Nam Cao <namcaov@gmail.com>
Subject: [PATCH] staging: sm750fb: add necessary #include in sm750_accel.h, sm750_cursor.h
Date: Fri, 18 Mar 2022 17:50:46 +0100 [thread overview]
Message-ID: <20220318165046.33745-1-namcaov@gmail.com> (raw)
In sm750_cursor.h, struct lynx_cursor is used without including the
header file where this struct is defined. Similar thing is seen in
sm750_accel.h.
The module can still be compiled because there is "#include "sm750.h""
before every "#include "sm750_accel.h"" and "#include "sm750_cursor.h"".
However, the order of #include should not affect the ability to compile.
Add "#include "sm750.h"" to sm750_accel.h and sm750_cursor.h.
Signed-off-by: Nam Cao <namcaov@gmail.com>
---
drivers/staging/sm750fb/sm750_accel.h | 2 ++
drivers/staging/sm750fb/sm750_cursor.h | 2 ++
2 files changed, 4 insertions(+)
diff --git a/drivers/staging/sm750fb/sm750_accel.h b/drivers/staging/sm750fb/sm750_accel.h
index 2c79cb730a0a..fe6ff196272c 100644
--- a/drivers/staging/sm750fb/sm750_accel.h
+++ b/drivers/staging/sm750fb/sm750_accel.h
@@ -2,6 +2,8 @@
#ifndef ACCEL_H__
#define ACCEL_H__
+#include "sm750.h"
+
#define HW_ROP2_COPY 0xc
#define HW_ROP2_XOR 0x6
diff --git a/drivers/staging/sm750fb/sm750_cursor.h b/drivers/staging/sm750fb/sm750_cursor.h
index b59643dd61ed..f023b691ac0b 100644
--- a/drivers/staging/sm750fb/sm750_cursor.h
+++ b/drivers/staging/sm750fb/sm750_cursor.h
@@ -2,6 +2,8 @@
#ifndef LYNX_CURSOR_H__
#define LYNX_CURSOR_H__
+#include "sm750.h"
+
/* hw_cursor_xxx works for voyager,718 and 750 */
void sm750_hw_cursor_enable(struct lynx_cursor *cursor);
void sm750_hw_cursor_disable(struct lynx_cursor *cursor);
--
2.25.1
next reply other threads:[~2022-03-18 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 16:50 Nam Cao [this message]
2022-03-29 14:51 ` [PATCH] staging: sm750fb: add necessary #include in sm750_accel.h, sm750_cursor.h Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220318165046.33745-1-namcaov@gmail.com \
--to=namcaov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox