Re: [PATCH] winmate-fm07-keys: Winmate FM07/FM07P buttons

Hans de Goede
2022-03-22T11:28:15Z

Hi,

On 3/21/22 20:32, Daniel Beer wrote:
> On Mon, Mar 21, 2022 at 11:22:40AM +0100, Hans de Goede wrote:
>> Do you have control of the firmware on this device?
>>
>> If yes then IMHO it would be better to implement this in ACPI
>> using the intel-hid fw API for this, see:
>
> Hi Hans,
>
> Unfortunately not. I don't work for Winmate and they haven't provided
> any documentation on this.

Ok, in that case please send a v2 addressing Barnabás' remarks.

I'll do a full review of v2 and then depending on what I find
merge it, or ask you to do a v3.

Regards,

Hans