From: Xin Hao <xhao@linux.alibaba.com>
To: kbusch@kernel.org
Cc: axboe@fb.com, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] nvme-pci: make use_threaded_interrupts mod-param read-only
Date: Tue, 22 Mar 2022 10:35:12 +0800 [thread overview]
Message-ID: <20220322023512.98644-1-xhao@linux.alibaba.com> (raw)
When I execute "insmod nvme.ko use_threaded_interrupts=1",
I find it difficult to determine whether it is successful
or not, So I want to add read-only parameter to
'/sys/module/nvme/parameters/use_threaded_interrupts',
When insmoded successfully.
# cat /sys/module/nvme/parameters/use_threaded_interrupts
# 1
Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
---
drivers/nvme/host/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 6a99ed680915..27cd20130021 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -44,7 +44,7 @@
#define NVME_MAX_SEGS 127
static int use_threaded_interrupts;
-module_param(use_threaded_interrupts, int, 0);
+module_param(use_threaded_interrupts, int, 0444);
static bool use_cmb_sqes = true;
module_param(use_cmb_sqes, bool, 0444);
--
2.31.0
next reply other threads:[~2022-03-22 2:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 2:35 Xin Hao [this message]
2022-03-23 8:20 ` [PATCH] nvme-pci: make use_threaded_interrupts mod-param read-only Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220322023512.98644-1-xhao@linux.alibaba.com \
--to=xhao@linux.alibaba.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox