From: "Darrick J. Wong" <djwong@kernel.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] xfs: clean up some inconsistent indenting
Date: Mon, 21 Mar 2022 19:51:11 -0700 [thread overview]
Message-ID: <20220322025111.GN8224@magnolia> (raw)
In-Reply-To: <20220322001137.96594-1-yang.lee@linux.alibaba.com>
On Tue, Mar 22, 2022 at 08:11:37AM +0800, Yang Li wrote:
> Eliminate the follow smatch warning:
> fs/xfs/xfs_log.c:3702 xlog_verify_tail_lsn() warn: inconsistent
> indenting
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
https://lore.kernel.org/linux-xfs/20210902233137.GB1826899@dread.disaster.area/
?
--D
> ---
> fs/xfs/xfs_log.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index a8034c0afdf2..5c8843026468 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -3699,21 +3699,21 @@ xlog_verify_tail_lsn(
> xfs_lsn_t tail_lsn = be64_to_cpu(iclog->ic_header.h_tail_lsn);
> int blocks;
>
> - if (CYCLE_LSN(tail_lsn) == log->l_prev_cycle) {
> - blocks =
> - log->l_logBBsize - (log->l_prev_block - BLOCK_LSN(tail_lsn));
> + if (CYCLE_LSN(tail_lsn) == log->l_prev_cycle) {
> + blocks = log->l_logBBsize -
> + (log->l_prev_block - BLOCK_LSN(tail_lsn));
> if (blocks < BTOBB(iclog->ic_offset)+BTOBB(log->l_iclog_hsize))
> xfs_emerg(log->l_mp, "%s: ran out of log space", __func__);
> - } else {
> - ASSERT(CYCLE_LSN(tail_lsn)+1 == log->l_prev_cycle);
> + } else {
> + ASSERT(CYCLE_LSN(tail_lsn)+1 == log->l_prev_cycle);
>
> - if (BLOCK_LSN(tail_lsn) == log->l_prev_block)
> - xfs_emerg(log->l_mp, "%s: tail wrapped", __func__);
> + if (BLOCK_LSN(tail_lsn) == log->l_prev_block)
> + xfs_emerg(log->l_mp, "%s: tail wrapped", __func__);
>
> - blocks = BLOCK_LSN(tail_lsn) - log->l_prev_block;
> - if (blocks < BTOBB(iclog->ic_offset) + 1)
> - xfs_emerg(log->l_mp, "%s: ran out of log space", __func__);
> - }
> + blocks = BLOCK_LSN(tail_lsn) - log->l_prev_block;
> + if (blocks < BTOBB(iclog->ic_offset) + 1)
> + xfs_emerg(log->l_mp, "%s: ran out of log space", __func__);
> + }
> }
>
> /*
> --
> 2.20.1.7.g153144c
>
next prev parent reply other threads:[~2022-03-22 2:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 0:11 [PATCH -next] xfs: clean up some inconsistent indenting Yang Li
2022-03-22 2:51 ` Darrick J. Wong [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-07-05 1:57 Yang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220322025111.GN8224@magnolia \
--to=djwong@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox