From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F70BC433F5 for ; Tue, 22 Mar 2022 17:39:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239790AbiCVRlO (ORCPT ); Tue, 22 Mar 2022 13:41:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239787AbiCVRlK (ORCPT ); Tue, 22 Mar 2022 13:41:10 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 97929888ED; Tue, 22 Mar 2022 10:39:39 -0700 (PDT) Received: from sequoia (162-237-133-238.lightspeed.rcsntx.sbcglobal.net [162.237.133.238]) by linux.microsoft.com (Postfix) with ESMTPSA id 7A9A520DE47A; Tue, 22 Mar 2022 10:39:38 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7A9A520DE47A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1647970779; bh=PtoDzmpopQFbgY2xTih9vlGwSqLfSUwf2Sb2AlNYui8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZFY4mGZeTZxZubHGDUEMEI3uzak1GNiVV7uxJ3M2ACpQgDK88FSTC/razs0NRr/HY PumUlS81DS9EPqFCos4W04o1DJ2f9iVq7b1jSbBHiZd/WlYzpRNaqYEKfGYs7Fh/5o u6jQlQ1UdFqfPsvtfRoK0djRD0w2yaIzeYoq5Dws= Date: Tue, 22 Mar 2022 12:39:32 -0500 From: Tyler Hicks To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: Jarkko Sakkinen , David Howells , "David S . Miller" , David Woodhouse , Eric Snowberg , Paul Moore , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Subject: Re: [PATCH v2 1/1] certs: Explain the rationale to call panic() Message-ID: <20220322173932.GB7173@sequoia> References: <20220322111323.542184-1-mic@digikod.net> <20220322111323.542184-2-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220322111323.542184-2-mic@digikod.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-03-22 12:13:23, Mickaël Salaün wrote: > From: Mickaël Salaün > > The blacklist_init() function calls panic() for memory allocation > errors. This change documents the reason why we don't return -ENODEV. > > Suggested-by: Paul Moore [1] > Requested-by: Jarkko Sakkinen [1] > Link: https://lore.kernel.org/r/YjeW2r6Wv55Du0bJ@iki.fi [1] > Reviewed-by: Paul Moore > Reviewed-by: Jarkko Sakkinen > Signed-off-by: Mickaël Salaün > Link: https://lore.kernel.org/r/20220322111323.542184-2-mic@digikod.net Reviewed-by: Tyler Hicks Tyler > --- > > Changes since v1: > * Fix commit subject spelling spotted by David Woodhouse. > * Reword one sentence as suggested by Paul Moore. > * Add Reviewed-by Paul Moore. > * Add Reviewed-by Jarkko Sakkinen. > --- > certs/blacklist.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/certs/blacklist.c b/certs/blacklist.c > index 486ce0dd8e9c..25094ea73600 100644 > --- a/certs/blacklist.c > +++ b/certs/blacklist.c > @@ -307,6 +307,15 @@ static int restrict_link_for_blacklist(struct key *dest_keyring, > > /* > * Initialise the blacklist > + * > + * The blacklist_init() function is registered as an initcall via > + * device_initcall(). As a result if the blacklist_init() function fails for > + * any reason the kernel continues to execute. While cleanly returning -ENODEV > + * could be acceptable for some non-critical kernel parts, if the blacklist > + * keyring fails to load it defeats the certificate/key based deny list for > + * signed modules. If a critical piece of security functionality that users > + * expect to be present fails to initialize, panic()ing is likely the right > + * thing to do. > */ > static int __init blacklist_init(void) > { > -- > 2.35.1 >