Re: [PATCH] x86/mm/tlb: avoid reading mm_tlb_gen when possible

Dave Hansen
2022-06-06T15:36:16Z

On 3/22/22 15:07, Nadav Amit wrote:
> + if (f->new_tlb_gen <= local_tlb_gen) {
> + /*
> + * We are already up to date in respect to f->new_tlb_gen.
> + * While the core might be still behind mm_tlb_gen, checking
> + * mm_tlb_gen unnecessarily would have negative caching effects
> + * so avoid it.
> + */
> + return;
> + }
> +

Nit: There's at least one "we" in here that needs to get fixed up. I'll
plan to do that when I apply it, but a v2 with that fixed and Peter's
ack added might save me five minutes.