Re: [PATCH v3 4/4] usb: host: add xhci-exynos driver

kernel test robot
2022-03-21T16:27:18Z

Hi Daehwan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20220318]
[also build test ERROR on v5.17]
[cannot apply to usb/usb-testing krzk/for-next char-misc/char-misc-testing v5.17 v5.17-rc8 v5.17-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Daehwan-Jung/usb-host-export-symbols-for-xhci-hooks-usage/20220321-180046
base: 6d72dda014a4753974eb08950089ddf71fec4f60
config: nios2-allyesconfig (https://download.01.org/0day-ci/archive/20220322/202203220053.4OkItVxU-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/517a7258fc6a2861b66ae9893b39d8bd4d6739e7
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Daehwan-Jung/usb-host-export-symbols-for-xhci-hooks-usage/20220321-180046
git checkout 517a7258fc6a2861b66ae9893b39d8bd4d6739e7
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/usb/host/xhci-exynos.c: In function 'xhci_priv_exynos_setup':
drivers/usb/host/xhci-exynos.c:55:18: error: 'struct xhci_plat_priv' has no member named 'plat_setup'
55 | if (!priv->plat_setup)
| ^~
drivers/usb/host/xhci-exynos.c:58:20: error: 'struct xhci_plat_priv' has no member named 'plat_setup'
58 | return priv->plat_setup(hcd);
| ^~
drivers/usb/host/xhci-exynos.c: In function 'xhci_exynos_free_container_ctx':
>> drivers/usb/host/xhci-exynos.c:146:17: error: implicit declaration of function 'dma_pool_free'; did you mean 'mempool_free'? [-Werror=implicit-function-declaration]
146 | dma_pool_free(xhci->device_pool, ctx->bytes, ctx->dma);
| ^~~~~~~~~~~~~
| mempool_free
In file included from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/kasan-checks.h:5,
from include/asm-generic/rwonce.h:26,
from ./arch/nios2/include/generated/asm/rwonce.h:1,
from include/linux/compiler.h:248,
from include/linux/err.h:5,
from include/linux/clk.h:12,
from drivers/usb/host/xhci-exynos.c:10:
drivers/usb/host/xhci-exynos.c: In function 'xhci_exynos_bus_suspend':
include/linux/stddef.h:8:14: error: called object is not a function or function pointer
8 | #define NULL ((void *)0)
| ^
drivers/usb/host/xhci.h:2190:33: note: in expansion of macro 'NULL'
2190 | #define xhci_bus_suspend NULL
| ^~~~
drivers/usb/host/xhci-exynos.c:234:15: note: in expansion of macro 'xhci_bus_suspend'
234 | ret = xhci_bus_suspend(hcd);
| ^~~~~~~~~~~~~~~~
drivers/usb/host/xhci-exynos.c: In function 'xhci_exynos_bus_resume':
include/linux/stddef.h:8:14: error: called object is not a function or function pointer
8 | #define NULL ((void *)0)
| ^
drivers/usb/host/xhci.h:2191:33: note: in expansion of macro 'NULL'
2191 | #define xhci_bus_resume NULL
| ^~~~
drivers/usb/host/xhci-exynos.c:252:15: note: in expansion of macro 'xhci_bus_resume'
252 | ret = xhci_bus_resume(hcd);
| ^~~~~~~~~~~~~~~
drivers/usb/host/xhci-exynos.c: In function 'xhci_exynos_address_device':
drivers/usb/host/xhci-exynos.c:260:26: warning: variable 'xhci' set but not used [-Wunused-but-set-variable]
260 | struct xhci_hcd *xhci;
| ^~~~
drivers/usb/host/xhci-exynos.c: In function 'xhci_exynos_parse_endpoint':
drivers/usb/host/xhci-exynos.c:276:29: warning: variable 'ep_ctx' set but not used [-Wunused-but-set-variable]
276 | struct xhci_ep_ctx *ep_ctx;
| ^~~~~~
drivers/usb/host/xhci-exynos.c: In function 'xhci_exynos_set_hc_event_deq_audio':
drivers/usb/host/xhci-exynos.c:370:20: warning: variable 'deq' set but not used [-Wunused-but-set-variable]
370 | dma_addr_t deq;
| ^~~
drivers/usb/host/xhci-exynos.c: At top level:
drivers/usb/host/xhci-exynos.c:576:10: error: 'const struct xhci_plat_priv' has no member named 'plat_setup'
576 | .plat_setup = xhci_mvebu_a3700_plat_setup,
| ^~~~~~~~~~
drivers/usb/host/xhci-exynos.c:576:23: error: 'xhci_mvebu_a3700_plat_setup' undeclared here (not in a function); did you mean 'xhci_mvebu_a3700_init_quirk'?
576 | .plat_setup = xhci_mvebu_a3700_plat_setup,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
| xhci_mvebu_a3700_init_quirk
drivers/usb/host/xhci-exynos.c: In function 'xhci_priv_exynos_setup':
drivers/usb/host/xhci-exynos.c:59:1: error: control reaches end of non-void function [-Werror=return-type]
59 | }
| ^
At top level:
drivers/usb/host/xhci-exynos.c:588:36: warning: 'xhci_plat_brcm' defined but not used [-Wunused-const-variable=]
588 | static const struct xhci_plat_priv xhci_plat_brcm = {
| ^~~~~~~~~~~~~~
drivers/usb/host/xhci-exynos.c:584:36: warning: 'xhci_plat_renesas_rcar_gen3' defined but not used [-Wunused-const-variable=]
584 | static const struct xhci_plat_priv xhci_plat_renesas_rcar_gen3 = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/usb/host/xhci-exynos.c:580:36: warning: 'xhci_plat_renesas_rcar_gen2' defined but not used [-Wunused-const-variable=]
580 | static const struct xhci_plat_priv xhci_plat_renesas_rcar_gen2 = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/usb/host/xhci-exynos.c:575:36: warning: 'xhci_plat_marvell_armada3700' defined but not used [-Wunused-const-variable=]
575 | static const struct xhci_plat_priv xhci_plat_marvell_armada3700 = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/usb/host/xhci-exynos.c:571:36: warning: 'xhci_plat_marvell_armada' defined but not used [-Wunused-const-variable=]
571 | static const struct xhci_plat_priv xhci_plat_marvell_armada = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +146 drivers/usb/host/xhci-exynos.c

141
142 static void xhci_exynos_free_container_ctx(struct xhci_hcd *xhci, struct xhci_container_ctx *ctx)
143 {
144 /* Ignore dma_pool_free if it is allocated from URAM */
145 if (ctx->dma != EXYNOS_URAM_DEVICE_CTX_ADDR)
> 146 dma_pool_free(xhci->device_pool, ctx->bytes, ctx->dma);
147 }
148

--
0-DAY CI Kernel Test Service