Re: [PATCH v3 4/4] usb: host: add xhci-exynos driver

Jung Daehwan
2022-03-23T02:36:01Z

[-- Attachment #1: Type: text/plain, Size: 1607 bytes --]

On Tue, Mar 22, 2022 at 06:10:00PM +0100, Krzysztof Kozlowski wrote:
> On 21/03/2022 09:59, Daehwan Jung wrote:
> > This driver supports USB Audio offload with Co-processor.
>
> One do you need one more XHCI driver? How does it differ from existing
> and why existing cannot be extended?

I have some exynos specific features and that's because need own driver.
It's not good to modify other XHCI driver for my features.

Additinally, I've been developing some features with other IP or Co-Processors.
Extending is not enough to cover them and I think owning driver is also better
on structural view.

Best Regards,
Jung Daehwan

>
> > It only cares DCBAA, Device Context, Transfer Ring, Event Ring, and ERST.
> > They are allocated on specific address with xhci hooks.
> > Co-processor could use them directly without xhci driver after then.
> >
> > Signed-off-by: Daehwan Jung <dh10.jung@samsung.com>
> > ---
> > drivers/usb/host/Kconfig | 9 +
> > drivers/usb/host/Makefile | 1 +
> > drivers/usb/host/xhci-exynos.c | 982 +++++++++++++++++++++++++++++++++
> > drivers/usb/host/xhci-exynos.h | 63 +++
> > 4 files changed, 1055 insertions(+)
> > create mode 100644 drivers/usb/host/xhci-exynos.c
> > create mode 100644 drivers/usb/host/xhci-exynos.h
> >
>
> Please address all the questions I raised in your v1, do not ignore them.
>
> Please use get_maintainers.pl to CC all necessary people and lists. It
> makes me very sad that you do not follow the kernel development process
> (as mentioned in submitting-patches.rst and other documents).
>
> Best regards,
> Krzysztof
>

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]