* [PATCH] nvme-pci: make use_threaded_interrupts mod-param read-only
@ 2022-03-22 2:35 Xin Hao
2022-03-23 8:20 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Xin Hao @ 2022-03-22 2:35 UTC (permalink / raw)
To: kbusch; +Cc: axboe, hch, sagi, linux-nvme, linux-kernel
When I execute "insmod nvme.ko use_threaded_interrupts=1",
I find it difficult to determine whether it is successful
or not, So I want to add read-only parameter to
'/sys/module/nvme/parameters/use_threaded_interrupts',
When insmoded successfully.
# cat /sys/module/nvme/parameters/use_threaded_interrupts
# 1
Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
---
drivers/nvme/host/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 6a99ed680915..27cd20130021 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -44,7 +44,7 @@
#define NVME_MAX_SEGS 127
static int use_threaded_interrupts;
-module_param(use_threaded_interrupts, int, 0);
+module_param(use_threaded_interrupts, int, 0444);
static bool use_cmb_sqes = true;
module_param(use_cmb_sqes, bool, 0444);
--
2.31.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nvme-pci: make use_threaded_interrupts mod-param read-only
2022-03-22 2:35 [PATCH] nvme-pci: make use_threaded_interrupts mod-param read-only Xin Hao
@ 2022-03-23 8:20 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2022-03-23 8:20 UTC (permalink / raw)
To: Xin Hao; +Cc: kbusch, axboe, hch, sagi, linux-nvme, linux-kernel
Thanks,
applied to nvme-5.18.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-23 8:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-22 2:35 [PATCH] nvme-pci: make use_threaded_interrupts mod-param read-only Xin Hao
2022-03-23 8:20 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox