* [PATCH] lib/test: use after free in register_test_dev_kmod()
@ 2022-03-24 5:52 Dan Carpenter
2022-03-24 23:18 ` Luis Chamberlain
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-03-24 5:52 UTC (permalink / raw)
To: Luis Chamberlain
Cc: Andrew Morton, linux-kernel, linux-modules, kernel-janitors
The "test_dev" pointer is freed but then returned to the caller.
Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
lib/test_kmod.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/test_kmod.c b/lib/test_kmod.c
index ce1589391413..cb800b1d0d99 100644
--- a/lib/test_kmod.c
+++ b/lib/test_kmod.c
@@ -1149,6 +1149,7 @@ static struct kmod_test_device *register_test_dev_kmod(void)
if (ret) {
pr_err("could not register misc device: %d\n", ret);
free_test_dev_kmod(test_dev);
+ test_dev = NULL;
goto out;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-24 23:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-24 5:52 [PATCH] lib/test: use after free in register_test_dev_kmod() Dan Carpenter
2022-03-24 23:18 ` Luis Chamberlain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox