public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [RFC PATCH ogabbay] habanalabs: hl_ts_behavior can be static
  2022-03-24 21:29 [ogabbay:habanalabs-next 15/19] drivers/misc/habanalabs/common/memory.c:2137:28: sparse: sparse: symbol 'hl_ts_behavior' was not declared. Should it be static? kernel test robot
@ 2022-03-24 21:23 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-03-24 21:23 UTC (permalink / raw)
  To: Yuri Nudelman; +Cc: kbuild-all, linux-kernel, Oded Gabbay

drivers/misc/habanalabs/common/memory.c:2137:28: warning: symbol 'hl_ts_behavior' was not declared. Should it be static?

Fixes: 079c2434d6e8 ("habanalabs: convert ts to use unified memory manager")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 drivers/misc/habanalabs/common/memory.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/habanalabs/common/memory.c b/drivers/misc/habanalabs/common/memory.c
index a9bf1a5f4a867..003f0f145c090 100644
--- a/drivers/misc/habanalabs/common/memory.c
+++ b/drivers/misc/habanalabs/common/memory.c
@@ -2134,7 +2134,7 @@ static int hl_ts_alloc_buf(struct hl_mmap_mem_buf *buf, gfp_t gfp, void *args)
 	return -ENOMEM;
 }
 
-struct hl_mmap_mem_buf_ops hl_ts_behavior = {
+static struct hl_mmap_mem_buf_ops hl_ts_behavior = {
 	.mmap = hl_ts_mmap,
 	.alloc = hl_ts_alloc_buf,
 	.release = ts_buff_release,

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [ogabbay:habanalabs-next 15/19] drivers/misc/habanalabs/common/memory.c:2137:28: sparse: sparse: symbol 'hl_ts_behavior' was not declared. Should it be static?
@ 2022-03-24 21:29 kernel test robot
  2022-03-24 21:23 ` [RFC PATCH ogabbay] habanalabs: hl_ts_behavior can be static kernel test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2022-03-24 21:29 UTC (permalink / raw)
  To: Yuri Nudelman; +Cc: kbuild-all, linux-kernel, Oded Gabbay

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux.git habanalabs-next
head:   8893b113963d24b89844a072c968b042ae76aa46
commit: 079c2434d6e86f38700d7d8b37f16bfb31315f8f [15/19] habanalabs: convert ts to use unified memory manager
config: i386-randconfig-s002 (https://download.01.org/0day-ci/archive/20220325/202203250539.2vJ8t5I0-lkp@intel.com/config)
compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux.git/commit/?id=079c2434d6e86f38700d7d8b37f16bfb31315f8f
        git remote add ogabbay https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux.git
        git fetch --no-tags ogabbay habanalabs-next
        git checkout 079c2434d6e86f38700d7d8b37f16bfb31315f8f
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash drivers/misc/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/misc/habanalabs/common/memory.c:2137:28: sparse: sparse: symbol 'hl_ts_behavior' was not declared. Should it be static?

Please review and possibly fold the followup patch.

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-24 21:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-24 21:29 [ogabbay:habanalabs-next 15/19] drivers/misc/habanalabs/common/memory.c:2137:28: sparse: sparse: symbol 'hl_ts_behavior' was not declared. Should it be static? kernel test robot
2022-03-24 21:23 ` [RFC PATCH ogabbay] habanalabs: hl_ts_behavior can be static kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox