The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org
Cc: "Mark Brown" <broonie@kernel.org>,
	"Tudor Ambarus" <tudor.ambarus@microchip.com>,
	"Pratyush Yadav" <p.yadav@ti.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	linux-aspeed@lists.ozlabs.org, "Joel Stanley" <joel@jms.id.au>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	"Chin-Ting Kuo" <chin-ting_kuo@aspeedtech.com>,
	devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Potin Lai" <potin.lai@quantatw.com>,
	"Cédric Le Goater" <clg@kaod.org>
Subject: [PATCH v4 11/11] mtd: spi-nor: aspeed: set the decoding size to at least 2MB for AST2600
Date: Fri, 25 Mar 2022 11:08:49 +0100	[thread overview]
Message-ID: <20220325100849.2019209-12-clg@kaod.org> (raw)
In-Reply-To: <20220325100849.2019209-1-clg@kaod.org>

From: Potin Lai <potin.lai@quantatw.com>

In AST2600, the unit of SPI CEx decoding range register is 1MB, and end
address offset is set to the acctual offset - 1MB. If the flash only has
1MB, the end address will has same value as start address, which will
causing unexpected errors.

This patch set the decoding size to at least 2MB to avoid decoding errors.

Tested:
root@bletchley:~# dmesg | grep "aspeed-smc 1e631000.spi: CE0 window"
[   59.328134] aspeed-smc 1e631000.spi: CE0 window resized to 2MB (AST2600 Decoding)
[   59.343001] aspeed-smc 1e631000.spi: CE0 window [ 0x50000000 - 0x50200000 ] 2MB
root@bletchley:~# devmem 0x1e631030
0x00100000

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
[ clg : Ported on new spi-mem driver ]
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 drivers/spi/spi-aspeed-smc.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c
index 660451667a39..227797e13997 100644
--- a/drivers/spi/spi-aspeed-smc.c
+++ b/drivers/spi/spi-aspeed-smc.c
@@ -466,6 +466,8 @@ static int aspeed_spi_set_window(struct aspeed_spi *aspi,
  *   is correct.
  */
 static const struct aspeed_spi_data ast2500_spi_data;
+static const struct aspeed_spi_data ast2600_spi_data;
+static const struct aspeed_spi_data ast2600_fmc_data;
 
 static int aspeed_spi_chip_adjust_window(struct aspeed_spi_chip *chip,
 					 u32 local_offset, u32 size)
@@ -489,6 +491,17 @@ static int aspeed_spi_chip_adjust_window(struct aspeed_spi_chip *chip,
 			 chip->cs, size >> 20);
 	}
 
+	/*
+	 * The decoding size of AST2600 SPI controller should set at
+	 * least 2MB.
+	 */
+	if ((aspi->data == &ast2600_spi_data || aspi->data == &ast2600_fmc_data) &&
+	    size < SZ_2M) {
+		size = SZ_2M;
+		dev_info(aspi->dev, "CE%d window resized to %dMB (AST2600 Decoding)",
+			 chip->cs, size >> 20);
+	}
+
 	aspeed_spi_get_windows(aspi, windows);
 
 	/* Adjust this chip window */
-- 
2.34.1


  parent reply	other threads:[~2022-03-25 10:10 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-25 10:08 [PATCH v4 00/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem Cédric Le Goater
2022-03-25 10:08 ` [PATCH v4 01/11] ARM: dts: aspeed: Adjust "reg" property of FMC/SPI controllers Cédric Le Goater
2022-03-25 10:08 ` [PATCH v4 02/11] dt-bindings: spi: Add Aspeed SMC controllers device tree binding Cédric Le Goater
2022-03-30 19:19   ` Pratyush Yadav
2022-03-31  7:36     ` Cédric Le Goater
2022-03-31 12:20       ` Pratyush Yadav
2022-03-25 10:08 ` [PATCH v4 03/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem Cédric Le Goater
2022-03-29  8:56   ` Cédric Le Goater
2022-03-29 10:49     ` Mark Brown
2022-03-30 19:33   ` Pratyush Yadav
2022-04-04  7:06     ` Cédric Le Goater
2022-04-05 19:29       ` Pratyush Yadav
2022-03-25 10:08 ` [PATCH v4 04/11] spi: aspeed: Add support for direct mapping Cédric Le Goater
2022-03-30 19:45   ` Pratyush Yadav
2022-04-04  7:11     ` Cédric Le Goater
2022-04-05 19:27       ` Pratyush Yadav
2022-03-25 10:08 ` [PATCH v4 05/11] spi: aspeed: Adjust direct mapping to device size Cédric Le Goater
2022-03-25 10:08 ` [PATCH v4 06/11] spi: aspeed: Workaround AST2500 limitations Cédric Le Goater
2022-03-25 10:08 ` [PATCH v4 07/11] spi: aspeed: Add support for the AST2400 SPI controller Cédric Le Goater
2022-03-25 10:08 ` [PATCH v4 08/11] spi: aspeed: Calibrate read timings Cédric Le Goater
2022-03-30 11:53   ` Chin-Ting Kuo
2022-03-30 12:14     ` Cédric Le Goater
2022-03-31  2:46       ` Chin-Ting Kuo
2022-03-31  7:15         ` Cédric Le Goater
2022-03-31  8:34           ` Chin-Ting Kuo
2022-03-31 16:41   ` Pratyush Yadav
2022-04-04  7:30     ` Cédric Le Goater
2022-04-05 19:22       ` Pratyush Yadav
2022-03-25 10:08 ` [PATCH v4 09/11] ARM: dts: aspeed: Enable Dual SPI RX transfers Cédric Le Goater
2022-03-25 10:08 ` [PATCH v4 10/11] ARM: dts: aspeed-g4: Set spi-max-frequency for all flashes Cédric Le Goater
2022-03-25 10:08 ` Cédric Le Goater [this message]
2022-03-30 19:49   ` [PATCH v4 11/11] mtd: spi-nor: aspeed: set the decoding size to at least 2MB for AST2600 Pratyush Yadav
2022-04-01 14:12 ` [PATCH v4 00/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem Jae Hyun Yoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220325100849.2019209-12-clg@kaod.org \
    --to=clg@kaod.org \
    --cc=andrew@aj.id.au \
    --cc=broonie@kernel.org \
    --cc=chin-ting_kuo@aspeedtech.com \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=p.yadav@ti.com \
    --cc=potin.lai@quantatw.com \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=tudor.ambarus@microchip.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox