From: Masami Hiramatsu <mhiramat@kernel.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
X86 ML <x86@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Network Development <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
"Naveen N . Rao" <naveen.n.rao@linux.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH v13 bpf-next 1/1] rethook: x86: Add rethook x86 implementation
Date: Fri, 25 Mar 2022 11:21:14 +0900 [thread overview]
Message-ID: <20220325112114.4604291a58ee5b214ee334da@kernel.org> (raw)
In-Reply-To: <CAADnVQLfu+uDUmovM8sOJSnH=HGxMEtmjk4+nWsAR+Mdj2TTYg@mail.gmail.com>
On Thu, 24 Mar 2022 19:03:43 -0700
Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
> On Wed, Mar 23, 2022 at 4:41 AM Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >
> > On Wed, 23 Mar 2022 09:05:26 +0100
> > Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > > On Wed, Mar 23, 2022 at 11:34:59AM +0900, Masami Hiramatsu wrote:
> > > > Add rethook for x86 implementation. Most of the code has been copied from
> > > > kretprobes on x86.
> > >
> > > Right; as said, I'm really unhappy with growing a carbon copy of this
> > > stuff instead of sharing. Can we *please* keep it a single instance?
> >
> > OK, then let me update the kprobe side too.
> >
> > > Them being basically indentical, it should be trivial to have
> > > CONFIG_KPROBE_ON_RETHOOK (or somesuch) and just share this.
> >
> > Yes, ideally it should use CONFIG_HAVE_RETHOOK since the rethook arch port
> > must be a copy of the kretprobe implementation. But for safety, I think
> > having CONFIG_KPROBE_ON_RETHOOK is a good idea until replacing all kretprobe
> > implementations.
>
> Masami,
>
> you're respinning this patch to combine
> arch_rethook_trampoline and __kretprobe_trampoline
> right?
Yes, let me send the first patch set (for x86 at first).
BTW, can you review these 2 patches? These are only for the fprobes,
so it can be picked to bpf-next.
https://lore.kernel.org/all/164802091567.1732982.1242854551611267542.stgit@devnote2/T/#u
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2022-03-25 2:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 2:34 [PATCH v13 bpf-next 0/1] fprobe: Introduce fprobe function entry/exit probe Masami Hiramatsu
2022-03-23 2:34 ` [PATCH v13 bpf-next 1/1] rethook: x86: Add rethook x86 implementation Masami Hiramatsu
2022-03-23 8:05 ` Peter Zijlstra
2022-03-23 11:41 ` Masami Hiramatsu
2022-03-23 12:34 ` Peter Zijlstra
2022-03-23 15:14 ` Masami Hiramatsu
2022-03-25 2:03 ` Alexei Starovoitov
2022-03-25 2:21 ` Masami Hiramatsu [this message]
2022-03-25 2:41 ` Alexei Starovoitov
2022-03-23 5:42 ` [PATCH v13 bpf-next 0/1] fprobe: Introduce fprobe function entry/exit probe Masami Hiramatsu
2022-03-23 14:18 ` Mark Rutland
2022-03-23 14:55 ` Masami Hiramatsu
2022-03-23 16:47 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220325112114.4604291a58ee5b214ee334da@kernel.org \
--to=mhiramat@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=ast@kernel.org \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox